hwmon: Remove obsolete adm1021 and max6642 drivers
Subsystems (2)
Guenter Roeck
maintainerPATCH 1/1 hwmon: Remove obsolete adm1021 and max6642 drivers
ADM1021, MAX6642, and compatible chips are supported by the lm90 driver. Remove the obsolete stand-alone drivers to reduce maintenance overhead.
--- Documentation/hwmon/adm1021.rst | 153 ---------- Documentation/hwmon/index.rst | 2 - Documentation/hwmon/max6642.rst | 27 -- drivers/hwmon/Kconfig | 24 -- drivers/hwmon/Makefile | 2 - drivers/hwmon/adm1021.c | 505 -------------------------------- drivers/hwmon/max6642.c | 314 -------------------- 7 files changed, 1027 deletions(-) delete mode 100644 Documentation/hwmon/adm1021.rst delete mode 100644 Documentation/hwmon/max6642.rst delete mode 100644 drivers/hwmon/adm1021.c delete mode 100644 drivers/hwmon/max6642.c
Documentation/hwmon/adm1021.rst deleted +0 -153
@@ -1,153 +0,0 @@ -Kernel driver adm1021 -===================== - -Supported chips: - - * Analog Devices ADM1021 - - Prefix: 'adm1021' - - Addresses scanned: I2C 0x18 - 0x1a, 0x29 - 0x2b, 0x4c - 0x4e - - Datasheet: Publicly available at the Analog Devices website - - * Analog Devices ADM1021A/ADM1023 - - Prefix: 'adm1023' - - Addresses scanned: I2C 0x18 - 0x1a, 0x29 - 0x2b, 0x4c - 0x4e - - Datasheet: Publicly available at the Analog Devices website - - * Genesys Logic GL523SM - - Prefix: 'gl523sm' - - Addresses scanned: I2C 0x18 - 0x1a, 0x29 - 0x2b, 0x4c - 0x4e - - Datasheet: - - * Maxim MAX1617 - - Prefix: 'max1617' - - Addresses scanned: I2C 0x18 - 0x1a, 0x29 - 0x2b, 0x4c - 0x4e - - Datasheet: Publicly available at the Maxim website - - * Maxim MAX1617A - - Prefix: 'max1617a' - - Addresses scanned: I2C 0x18 - 0x1a, 0x29 - 0x2b, 0x4c - 0x4e - - Datasheet: Publicly available at the Maxim website - - * National Semiconductor LM84 - - Prefix: 'lm84' - - Addresses scanned: I2C 0x18 - 0x1a, 0x29 - 0x2b, 0x4c - 0x4e - - Datasheet: Publicly available at the National Semiconductor website - - * Philips NE1617 - - Prefix: 'max1617' (probably detected as a max1617) - - Addresses scanned: I2C 0x18 - 0x1a, 0x29 - 0x2b, 0x4c - 0x4e - - Datasheet: Publicly available at the Philips website - - * Philips NE1617A - - Prefix: 'max1617' (probably detected as a max1617) - - Addresses scanned: I2C 0x18 - 0x1a, 0x29 - 0x2b, 0x4c - 0x4e - - Datasheet: Publicly available at the Philips website - - * TI THMC10 - - Prefix: 'thmc10' - - Addresses scanned: I2C 0x18 - 0x1a, 0x29 - 0x2b, 0x4c - 0x4e - - Datasheet: Publicly available at the TI website - - * Onsemi MC1066 - - Prefix: 'mc1066' - - Addresses scanned: I2C 0x18 - 0x1a, 0x29 - 0x2b, 0x4c - 0x4e - - Datasheet: Publicly available at the Onsemi website - - -Authors: - - Frodo Looijaard <[email protected]>, - - Philip Edelbrock <[email protected]> - -Module Parameters ------------------ - -* read_only: int - Don't set any values, read only mode - - -Description ------------ - -The chips supported by this driver are very similar. The Maxim MAX1617 is -the oldest; it has the problem that it is not very well detectable. The -MAX1617A solves that. The ADM1021 is a straight clone of the MAX1617A. -Ditto for the THMC10. From here on, we will refer to all these chips as -ADM1021-clones. - -The ADM1021 and MAX1617A reports a die code, which is a sort of revision -code. This can help us pinpoint problems; it is not very useful -otherwise. - -ADM1021-clones implement two temperature sensors. One of them is internal, -and measures the temperature of the chip itself; the other is external and -is realised in the form of a transistor-like device. A special alarm -indicates whether the remote sensor is connected. - -Each sensor has its own low and high limits. When they are crossed, the -corresponding alarm is set and remains on as long as the temperature stays -out of range. Temperatures are measured in degrees Celsius. Measurements -are possible between -65 and +127 degrees, with a resolution of one degree. - -If an alarm triggers, it will remain triggered until the hardware register -is read at least once. This means that the cause for the alarm may already -have disappeared! - -This driver only updates its values each 1.5 seconds; reading it more often -will do no harm, but will return 'old' values. It is possible to make -ADM1021-clones do faster measurements, but there is really no good reason -for that. - - -Netburst-based Xeon support ---------------------------- - -Some Xeon processors based on the Netburst (early Pentium 4, from 2001 to -2003) microarchitecture had real MAX1617, ADM1021, or compatible chips -within them, with two temperature sensors. Other Xeon processors of this -era (with 400 MHz FSB) had chips with only one temperature sensor. - -If you have such an old Xeon, and you get two valid temperatures when -loading the adm1021 module, then things are good. - -If nothing happens when loading the adm1021 module, and you are certain -that your specific Xeon processor model includes compatible sensors, you -will have to explicitly instantiate the sensor chips from user-space. See -method 4 in Documentation/i2c/instantiating-devices.rst. Possible slave -addresses are 0x18, 0x1a, 0x29, 0x2b, 0x4c, or 0x4e. It is likely that -only temp2 will be correct and temp1 will have to be ignored. - -Previous generations of the Xeon processor (based on Pentium II/III) -didn't have these sensors. Next generations of Xeon processors (533 MHz -FSB and faster) lost them, until the Core-based generation which -introduced integrated digital thermal sensors. These are supported by -the coretemp driver.
Documentation/hwmon/index.rst +0 -2
@@ -25,7 +25,6 @@ Hardware Monitoring Kernel Drivers acpi_power_meter ad7314 adc128d818 - adm1021 adm1025 adm1026 adm1031
@@ -154,7 +153,6 @@ Hardware Monitoring Kernel Drivers max34440 max6620 max6639 - max6642 max6650 max6697 max8688
Documentation/hwmon/max6642.rst deleted +0 -27
@@ -1,27 +0,0 @@ -Kernel driver max6642 -===================== - -Supported chips: - - * Maxim MAX6642 - - Prefix: 'max6642' - - Addresses scanned: I2C 0x48-0x4f - - Datasheet: Publicly available at the Maxim website - - http://datasheets.maxim-ic.com/en/ds/MAX6642.pdf - -Authors: - - Per Dalen <[email protected]> - -Description ------------ - -The MAX6642 is a digital temperature sensor. It senses its own temperature as -well as the temperature on one external diode. - -All temperature values are given in degrees Celsius. Resolution -is 0.25 degree for the local temperature and for the remote temperature.
drivers/hwmon/Kconfig +0 -24
@@ -105,18 +105,6 @@ config SENSORS_AD7418 This driver can also be built as a module. If so, the module will be called ad7418. -config SENSORS_ADM1021 - tristate "Analog Devices ADM1021 and compatibles" - depends on I2C - depends on SENSORS_LM90=n - help - If you say yes here you get support for Analog Devices ADM1021 - and ADM1023 sensor chips and clones: Maxim MAX1617 and MAX1617A, - Genesys Logic GL523SM, National Semiconductor LM84 and TI THMC10. - - This driver can also be built as a module. If so, the module - will be called adm1021. - config SENSORS_ADM1025 tristate "Analog Devices ADM1025 and compatibles" depends on I2C
@@ -1241,18 +1229,6 @@ config SENSORS_MAX6639 This driver can also be built as a module. If so, the module will be called max6639. -config SENSORS_MAX6642 - tristate "Maxim MAX6642 sensor chip" - depends on I2C - depends on SENSORS_LM90=n - help - If you say yes here you get support for MAX6642 sensor chip. - MAX6642 is a SMBus-Compatible Remote/Local Temperature Sensor - with Overtemperature Alarm from Maxim. - - This driver can also be built as a module. If so, the module - will be called max6642. - config SENSORS_MAX6650 tristate "Maxim MAX6650 sensor chip" depends on I2C
drivers/hwmon/Makefile +0 -2
@@ -31,7 +31,6 @@ obj-$(CONFIG_SENSORS_AD7414) += ad7414.o obj-$(CONFIG_SENSORS_AD7418) += ad7418.o obj-$(CONFIG_SENSORS_ADC128D818) += adc128d818.o obj-$(CONFIG_SENSORS_ADCXX) += adcxx.o -obj-$(CONFIG_SENSORS_ADM1021) += adm1021.o obj-$(CONFIG_SENSORS_ADM1025) += adm1025.o obj-$(CONFIG_SENSORS_ADM1026) += adm1026.o obj-$(CONFIG_SENSORS_ADM1029) += adm1029.o
@@ -154,7 +153,6 @@ obj-$(CONFIG_SENSORS_MAX31760) += max31760.o obj-$(CONFIG_SENSORS_MAX6620) += max6620.o obj-$(CONFIG_SENSORS_MAX6621) += max6621.o obj-$(CONFIG_SENSORS_MAX6639) += max6639.o -obj-$(CONFIG_SENSORS_MAX6642) += max6642.o obj-$(CONFIG_SENSORS_MAX6650) += max6650.o obj-$(CONFIG_SENSORS_MAX6697) += max6697.o obj-$(CONFIG_SENSORS_MAX31790) += max31790.o
drivers/hwmon/adm1021.c deleted +0 -505
505 lines not on this page · raw message
drivers/hwmon/max6642.c deleted +0 -314
314 lines not on this page · raw message
Signature · 1 line
2.39.2
Quoted 1 line · Guenter Roeck
drivers/hwmon/adm1021.c +0
-0
[...]
drivers/hwmon/adm1021.c line 477
Quoted 5 lines
drivers/hwmon/adm1021.c +0
-5-static const struct i2c_device_id adm1021_id[] = { - {"adm1021" , adm1021 }, - {"adm1023" , adm1023 }, - {"max1617" , max1617 }, - {"max1617a" , max1617a },
The device ID "max1617a" only in Documentation/hwmon/lm90.rst but not in drivers/hwmon/lm90.c which results in max1617a is no longer supported after applying the patch.
Guenter Roeck
maintainerHi,
Quoted 13 lines · Tzung-Bi Shih
Quoted 1 line · Guenter Roeck
drivers/hwmon/adm1021.c +0
-0[...]
drivers/hwmon/adm1021.c line 477
Quoted 5 lines
drivers/hwmon/adm1021.c +0
-5-static const struct i2c_device_id adm1021_id[] = { - {"adm1021" , adm1021 }, - {"adm1023" , adm1023 }, - {"max1617" , max1617 }, - {"max1617a" , max1617a },The device ID "max1617a" only in
Documentation/hwmon/lm90.rstbut not indrivers/hwmon/lm90.cwhich results in max1617a is no longer supported after applying the patch.
Thanks for noticing. It is an oversight, really. The chip is the same. max1617a is even mentioned in the lm90 documentation.
The chip is detected and supported as "max1617" in the lm90 driver. Here are the notes from that driver.
* Note: Multiple chips with different markings labeled as
* "MAX1617" (no "A") were observed to report manufacturer ID
* 0x4d and device ID 0x01. It is unknown if other variants of
* MAX1617/MAX617A with different behavior exist. The detection
* code below works for those chips.
Not sure if I should mark the chips as max1617a instead of max1617 or just update the documentation.
Either case, all configurations enabling the adm1021 driver also enable the lm90 driver, and that in turn prevents the adm1021 driver from being built. Effectively that means that the adm1021 driver hasn't been built for a long time.
Thanks,
Guenter
Tzung-Bi Shih
Reviewed-byQuoted 20 lines · Guenter Roeck
Quoted 13 lines · Tzung-Bi Shih
Quoted 1 line · Guenter Roeck
drivers/hwmon/adm1021.c +0
-0[...]
drivers/hwmon/adm1021.c line 477
Quoted 5 lines
drivers/hwmon/adm1021.c +0
-5-static const struct i2c_device_id adm1021_id[] = { - {"adm1021" , adm1021 }, - {"adm1023" , adm1023 }, - {"max1617" , max1617 }, - {"max1617a" , max1617a },The device ID "max1617a" only in
Documentation/hwmon/lm90.rstbut not indrivers/hwmon/lm90.cwhich results in max1617a is no longer supported after applying the patch.Thanks for noticing. It is an oversight, really. The chip is the same. max1617a is even mentioned in the lm90 documentation.
The chip is detected and supported as "max1617" in the lm90 driver. Here are the notes from that driver.
Quoted 5 lines
* Note: Multiple chips with different markings labeled as
* "MAX1617" (no "A") were observed to report manufacturer ID
*0x4dand device ID0x01. It is unknown if other variants of
* MAX1617/MAX617A with different behavior exist. The detection
* code below works for those chips.
Ack.
Quoted 4 lines
Either case, all configurations enabling the adm1021 driver also enable the lm90 driver, and that in turn prevents the adm1021 driver from being built. Effectively that means that the adm1021 driver hasn't been built for a long time.
Curious about how this happens: is there a way for telling build system that we prefer lm90 to adm1021?
Guenter Roeck
maintainerQuoted 31 lines · Tzung-Bi Shih
Quoted 20 lines · Guenter Roeck
Quoted 13 lines · Tzung-Bi Shih
Quoted 1 line · Guenter Roeck
drivers/hwmon/adm1021.c +0
-0[...]
drivers/hwmon/adm1021.c line 477
Quoted 5 lines
drivers/hwmon/adm1021.c +0
-5-static const struct i2c_device_id adm1021_id[] = { - {"adm1021" , adm1021 }, - {"adm1023" , adm1023 }, - {"max1617" , max1617 }, - {"max1617a" , max1617a },The device ID "max1617a" only in
Documentation/hwmon/lm90.rstbut not indrivers/hwmon/lm90.cwhich results in max1617a is no longer supported after applying the patch.Thanks for noticing. It is an oversight, really. The chip is the same. max1617a is even mentioned in the lm90 documentation.
The chip is detected and supported as "max1617" in the lm90 driver. Here are the notes from that driver.Quoted 5 lines
* Note: Multiple chips with different markings labeled as
* "MAX1617" (no "A") were observed to report manufacturer ID
*0x4dand device ID0x01. It is unknown if other variants of
* MAX1617/MAX617A with different behavior exist. The detection
* code below works for those chips.Ack.
Reviewed-by Tzung-Bi Shih <[email protected]>
Quoted 8 lines
Quoted 4 lines
Either case, all configurations enabling the adm1021 driver also enable the lm90 driver, and that in turn prevents the adm1021 driver from being built. Effectively that means that the adm1021 driver hasn't been built for a long time.
Curious about how this happens: is there a way for telling build system that we prefer lm90 to adm1021?
This was
config SENSORS_ADM1021
tristate "Analog Devices ADM1021 and compatibles" depends on I2C
depends on SENSORS_LM90=n ^^^^^^^^^^^^^^^^^^^^^^^^^
Thanks,
Guenter