Skip to contentSkip to conversation

drm/test: fix the gem shmem test to map the sg table.

PATCH New Dave Airlie 1 participant 1 message Jul 15, 2024

Subsystems (2)
lore
Share & tools
lore

Dave Airlie

author maintainer
#0 lore raw

PATCH 1/1 drm/test: fix the gem shmem test to map the sg table.

From: Dave Airlie <[email protected]>

The test here creates an sg table, but never maps it, when we get to drm_gem_shmem_free, the helper tries to unmap and this causes warnings on some platforms and debug kernels.

For now, set the dma mask (to avoid swiotlb) and map the sgtable.

Fixes 93032ae634d4 ("drm/test: add a test suite for GEM objects backed by shmem")
---
 drivers/gpu/drm/tests/drm_gem_shmem_test.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
drivers/gpu/drm/tests/drm_gem_shmem_test.c +11 -0
index 91202e40cde9..eb3a7a84be90 100644
@@ -102,6 +102,17 @@ static void drm_gem_shmem_test_obj_create_private(struct kunit *test)
 
 	sg_init_one(sgt->sgl, buf, TEST_SIZE);
 
+	/*
+	 * Set the DMA mask to 64-bits and map the sgtables
+	 * otherwise drm_gem_shmem_free will cause a warning
+	 * on debug kernels.
+	 * */
+	ret = dma_set_mask(drm_dev->dev, DMA_BIT_MASK(64));
+	KUNIT_ASSERT_EQ(test, ret, 0);
+
+	ret = dma_map_sgtable(drm_dev->dev, sgt, DMA_BIDIRECTIONAL, 0);
+	KUNIT_ASSERT_EQ(test, ret, 0);
+
 	/* Init a mock DMA-BUF */
 	buf_mock.size = TEST_SIZE;
 	attach_mock.dmabuf = &buf_mock;
Signature · 1 line
2.45.0