kallsyms: get rid of code for absolute kallsyms
Subsystems (2)
PATCH 1/1 kallsyms: get rid of code for absolute kallsyms
From: Jann Horn <[email protected]>
Commit cf8e8658100d ("arch: Remove Itanium (IA-64) architecture") removed the last use of the absolute kallsyms.
Signed-off-by Jann Horn <[email protected]>
Acked-by Arnd Bergmann <[email protected]>
[[email protected]: rebase the code and reword the commit description]
Signed-off-by Masahiro Yamada <[email protected]>
---
init/Kconfig | 18 ------- kernel/kallsyms.c | 5 +- kernel/kallsyms_internal.h | 1 - kernel/vmcore_info.c | 4 -- scripts/kallsyms.c | 76 ++++++++++++----------------- scripts/link-vmlinux.sh | 4 -- tools/perf/tests/vmlinux-kallsyms.c | 1 - 7 files changed, 32 insertions(+), 77 deletions(-)
init/Kconfig +0 -18
@@ -1789,24 +1789,6 @@ config KALLSYMS_ABSOLUTE_PERCPU depends on KALLSYMS default X86_64 && SMP -config KALLSYMS_BASE_RELATIVE - bool - depends on KALLSYMS - default y - help - Instead of emitting them as absolute values in the native word size, - emit the symbol references in the kallsyms table as 32-bit entries, - each containing a relative value in the range [base, base + U32_MAX] - or, when KALLSYMS_ABSOLUTE_PERCPU is in effect, each containing either - an absolute value in the range [0, S32_MAX] or a relative value in the - range [base, base + S32_MAX], where base is the lowest relative symbol - address encountered in the image. - - On 64-bit builds, this reduces the size of the address table by 50%, - but more importantly, it results in entries whose values are build - time constants, and no relocation pass is required at runtime to fix - up the entries based on the runtime load address of the kernel. - # end of the "standard kernel features (expert users)" menu config ARCH_HAS_MEMBARRIER_CALLBACKS
kernel/kallsyms.c +1 -4
@@ -148,9 +148,6 @@ static unsigned int get_symbol_offset(unsigned long pos)unsigned long kallsyms_sym_address (int idx) { -if (!IS_ENABLED (CONFIG_KALLSYMS_BASE_RELATIVE )) -return kallsyms_addresses[idx]; -/* values are unsigned offsets if --absolute-percpu is not in effect */ if (!IS_ENABLED (CONFIG_KALLSYMS_ABSOLUTE_PERCPU ))return kallsyms_relative_base + (u32 )kallsyms_offsets[idx];
@@ -325,7 +322,7 @@ static unsigned long get_symbol_pos(unsigned long addr,unsigned long symbol_start =0 , symbol_end =0 ;unsigned long i, low, high, mid; -/* Do a binary search on the sorted kallsyms_addresses array. */ +/* Do a binary search on the sorted kallsyms_offsets array. */ low =0 ; high = kallsyms_num_syms;
kernel/kallsyms_internal.h +0 -1
@@ -4,7 +4,6 @@#include <linux/types.h> -extern const unsigned long kallsyms_addresses[];extern const int kallsyms_offsets[];extern const u8 kallsyms_names[];
kernel/vmcore_info.c +0 -4
@@ -216,12 +216,8 @@ static int __init crash_save_vmcoreinfo_init(void)VMCOREINFO_SYMBOL (kallsyms_num_syms);VMCOREINFO_SYMBOL (kallsyms_token_table);VMCOREINFO_SYMBOL (kallsyms_token_index); -#ifdef CONFIG_KALLSYMS_BASE_RELATIVE VMCOREINFO_SYMBOL (kallsyms_offsets);VMCOREINFO_SYMBOL (kallsyms_relative_base); -#else -VMCOREINFO_SYMBOL (kallsyms_addresses); -#endif /* CONFIG_KALLSYMS_BASE_RELATIVE */ #endif /* CONFIG_KALLSYMS */ arch_crash_save_vmcoreinfo ();
scripts/kallsyms.c +31 -45
121 lines not on this page · raw message
scripts/link-vmlinux.sh +0 -4
@@ -156,10 +156,6 @@ kallsyms() kallsymopt="${kallsymopt} --absolute-percpu" fi - if is_enabled CONFIG_KALLSYMS_BASE_RELATIVE; then - kallsymopt="${kallsymopt} --base-relative" - fi - if is_enabled CONFIG_LTO_CLANG; then kallsymopt="${kallsymopt} --lto-clang" fi
tools/perf/tests/vmlinux-kallsyms.c +0 -1
@@ -26,7 +26,6 @@ static bool is_ignored_symbol(const char *name, char type)* when --all-symbols is specified so exclude them to get a * stable symbol list. */ -"kallsyms_addresses" ,"kallsyms_offsets" ,"kallsyms_relative_base" , "kallsyms_num_syms",
Signature · 1 line
2.43.0
Quoted 6 lines · Masahiro Yamada
From: Jann Horn <[email protected]>
Commit
cf8e8658100d("arch: Remove Itanium (IA-64) architecture") removed the last use of the absolute kallsyms.
Quoted 6 lines
Signed-off-by Jann Horn <[email protected]>Acked-by Arnd Bergmann <[email protected]>[[email protected]: rebase the code and reword the commit description]Signed-off-by Masahiro Yamada <[email protected]>---
Applied to linux-kbuild.
Thanks!
Signature · 2 lines
Best Regards Masahiro Yamada