Kconfig: reduce the amount of power sequencing noise
PATCH v2 1/1 Kconfig: reduce the amount of power sequencing noise
From: Bartosz Golaszewski <[email protected]>
Kconfig will ask the user twice about power sequencing: once for the QCom WCN power sequencing driver and then again for the PCI power control driver using it.
Let's automate the selection of PCI_PWRCTL by introducing a new hidden
symbol: HAVE_PWRCTL which should be selected by all platforms that have the need to include PCI power control code (right now: only ARCH_QCOM).
The pwrseq-based PCI pwrctl driver itself will then be selected by the drivers binding to devices that may require external handling of the power-up sequence (currently: ath11k and ath12k) based on the value of HAVE_PWRCTL.
Make all PCI pwrctl Kconfig symbols hidden so that no questions are asked during configuration.
---
I'm sending it as a single patch for more clarity as it most likely will end up being picked up by Linus directly.
Changes in v2:
- introduce new HAVE_PWRCTL symbol and select it from ARCH_QCOM
- select PCI_PWRCTL from the relevant drivers
arch/arm64/Kconfig.platforms | 1 + drivers/net/wireless/ath/ath11k/Kconfig | 1 + drivers/net/wireless/ath/ath12k/Kconfig | 1 + drivers/pci/pwrctl/Kconfig | 11 +++-------- 4 files changed, 6 insertions(+), 8 deletions(-)
arch/arm64/Kconfig.platforms +1 -0
@@ -266,6 +266,7 @@ config ARCH_QCOM bool "Qualcomm Platforms" select GPIOLIB select PINCTRL + select HAVE_PWRCTL help This enables support for the ARMv8 based Qualcomm chipsets.
drivers/net/wireless/ath/ath11k/Kconfig +1 -0
@@ -24,6 +24,7 @@ config ATH11K_PCI select MHI_BUS select QRTR select QRTR_MHI + select PCI_PWRCTL_PWRSEQ if HAVE_PWRCTL help This module adds support for PCIE bus
drivers/net/wireless/ath/ath12k/Kconfig +1 -0
@@ -7,6 +7,7 @@ config ATH12K select MHI_BUS select QRTR select QRTR_MHI + select PCI_PWRCTL_PWRSEQ if HAVE_PWRCTL help Enable support for Qualcomm Technologies Wi-Fi 7 (IEEE 802.11be) family of chipsets, for example WCN7850 and
drivers/pci/pwrctl/Kconfig +3 -8
@@ -1,17 +1,12 @@ # SPDX-License-Identifier: GPL-2.0-only -menu "PCI Power control drivers" +config HAVE_PWRCTL + bool config PCI_PWRCTL tristate config PCI_PWRCTL_PWRSEQ - tristate "PCI Power Control driver using the Power Sequencing subsystem" + tristate select POWER_SEQUENCING select PCI_PWRCTL - default m if ((ATH11K_PCI || ATH12K) && ARCH_QCOM) - help - Enable support for the PCI power control driver for device - drivers using the Power Sequencing subsystem. - -endmenu
Signature · 1 line
2.43.0
Quoted 15 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
Kconfigwill ask the user twice about power sequencing: once for the QCom WCN power sequencing driver and then again for the PCI power control driver using it.Let's automate the selection of
PCI_PWRCTLby introducing a new hidden
symbol:HAVE_PWRCTLwhich should be selected by all platforms that have the need to include PCI power control code (right now: onlyARCH_QCOM).The pwrseq-based PCI pwrctl driver itself will then be selected by the drivers binding to devices that may require external handling of the power-up sequence (currently: ath11k and ath12k) based on the value of
HAVE_PWRCTL.
Quoted 7 lines
Make all PCI pwrctl
Kconfigsymbols hidden so that no questions are asked during configuration.Fixes 4565d2652a37 ("PCI/pwrctl: Add PCI power control core code")Reported-by Linus Torvalds <[email protected]>Closes https://lore.kernel.org/lkml/CAHk-=wjWc5dzcj2O1tEgNHY1rnQW63JwtuZi_vAZPqy6wqpoUQ@mail.gmail.com/ open hereSigned-off-by Bartosz Golaszewski <[email protected]>
From: Bartosz Golaszewski <[email protected]>
Quoted 9 lines · Bartosz Golaszewski
Kconfigwill ask the user twice about power sequencing: once for the QCom WCN power sequencing driver and then again for the PCI power control driver using it.Let's automate the selection of
PCI_PWRCTLby introducing a new hidden
symbol:HAVE_PWRCTLwhich should be selected by all platforms that have the need to include PCI power control code (right now: onlyARCH_QCOM).[...]
I'm picking this up into my pwrseq/for-current branch. I'll be off next week so I want to give the autobuilders the chance to play with this and I'll send a PR to Linus with another pwrseq fix I have queued tomorrow evening.
Let me know if there are any objections.
[1/1] Kconfig: reduce the amount of power sequencing noise
commit: ed70aaac7c359540d3d8332827fa60b6a45e15f2
Best regards,
Signature · 1 line
Bartosz Golaszewski <[email protected]>