Skip to contentSkip to conversation

arm64: qcom: don't select HAVE_PWRCTL when PCI=n

PATCH In review Arnd Bergmann 2 participants 2 messages Jul 19, 2024 arm64

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: qcom: don't select HAVE_PWRCTL when PCI=n

From: Arnd Bergmann <[email protected]>

The new HAVE_PWRCTL option is defined in the PCI subsystem, so selecting it unconditionally when PCI is disabled causes a harmless warning:

WARNING: unmet direct dependencies detected for HAVE_PWRCTL
Depends on [n]: PCI [=n]
Selected by [y]:
- ARCH_QCOM [=y]

Add 'if PCI' in the qualcomm platform to hide the warning.

Fixes ed70aaac7c35 ("Kconfig: reduce the amount of power sequencing noise")
---
 arch/arm64/Kconfig.platforms | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/Kconfig.platforms +1 -1
index 9b62c63781ec..6c6d11536b42 100644
@@ -266,7 +266,7 @@ config ARCH_QCOM
 	bool "Qualcomm Platforms"
 	select GPIOLIB
 	select PINCTRL
-	select HAVE_PWRCTL
+	select HAVE_PWRCTL if PCI
 	help
 	  This enables support for the ARMv8 based Qualcomm chipsets.
 
Signature · 1 line
2.39.2
#1 lore raw
Quoted 34 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The new HAVE_PWRCTL option is defined in the PCI subsystem, so selecting it unconditionally when PCI is disabled causes a harmless warning:

WARNING: unmet direct dependencies detected for HAVE_PWRCTL
Depends on [n]: PCI [=n]
Selected by [y]:
- ARCH_QCOM [=y]

Add 'if PCI' in the qualcomm platform to hide the warning.

Fixes ed70aaac7c35 ("Kconfig: reduce the amount of power sequencing noise")
---
 arch/arm64/Kconfig.platforms | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/Kconfig.platforms +1 -2
index 9b62c63781ec..6c6d11536b42 100644
@@ -266,7 +266,7 @@ config ARCH_QCOM
        bool "Qualcomm Platforms"
        select GPIOLIB
        select PINCTRL
-       select HAVE_PWRCTL
+       select HAVE_PWRCTL if PCI
        help
          This enables support for the ARMv8 based Qualcomm chipsets.
 
--
Quoted 3 lines

2.39.2

I applied it manually. For some reason b4 cannot grab this from lore.

Bartosz