Skip to contentSkip to conversation

drm/omap: add CONFIG_MMU dependency

PATCH In review Arnd Bergmann 2 participants 2 messages Jul 19, 2024 – Aug 5, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/omap: add CONFIG_MMU dependency

From: Arnd Bergmann <[email protected]>

Compile-testing with CONFIG_MMU disabled causes a link error in omapdrm:

arm-linux-gnueabi-ld: drivers/gpu/drm/omapdrm/omap_gem.o: in function `omap_gem_fault_2d':
omap_gem.c:(.text+0x36e): undefined reference to `vmf_insert_mixed'
arm-linux-gnueabi-ld: drivers/gpu/drm/omapdrm/omap_gem.o: in function `omap_gem_fault':
omap_gem.c:(.text+0x74a): undefined reference to `vmf_insert_mixed'

Avoid this by adding a Kconfig dependency.

Fixes dc6fcaaba5a5 ("drm/omap: Allow build with COMPILE_TEST=y")
---
 drivers/gpu/drm/omapdrm/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/omapdrm/Kconfig +1 -0
index 3f7139e211d2..64e440a2649b 100644
@@ -1,6 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config DRM_OMAP
 	tristate "OMAP DRM"
+	depends on MMU
 	depends on DRM && OF
 	depends on ARCH_OMAP2PLUS || (COMPILE_TEST && PAGE_SIZE_LESS_THAN_64KB)
 	select DRM_KMS_HELPER
Signature · 1 line
2.39.2
maintainer
#1 lore raw

Hi,

Quoted 9 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

Compile-testing with CONFIG_MMU disabled causes a link error in omapdrm:

arm-linux-gnueabi-ld: drivers/gpu/drm/omapdrm/omap_gem.o: in function `omap_gem_fault_2d':
omap_gem.c:(.text+0x36e): undefined reference to `vmf_insert_mixed'
arm-linux-gnueabi-ld: drivers/gpu/drm/omapdrm/omap_gem.o: in function `omap_gem_fault':
omap_gem.c:(.text+0x74a): undefined reference to `vmf_insert_mixed'

Quoted 4 lines

Avoid this by adding a Kconfig dependency.

Fixes dc6fcaaba5a5 ("drm/omap: Allow build with COMPILE_TEST=y")

Thanks, applying to drm-misc-fixes.

Tomi

Quoted 16 lines
---
  drivers/gpu/drm/omapdrm/Kconfig | 1 +
  1 file changed, 1 insertion(+)
drivers/gpu/drm/omapdrm/Kconfig +1 -0
index 3f7139e211d2..64e440a2649b 100644
@@ -1,6 +1,7 @@
  # SPDX-License-Identifier: GPL-2.0-only
  config DRM_OMAP
  	tristate "OMAP DRM"
+	depends on MMU
  	depends on DRM && OF
  	depends on ARCH_OMAP2PLUS || (COMPILE_TEST && PAGE_SIZE_LESS_THAN_64KB)
  	select DRM_KMS_HELPER