f2fs: test for race condition in between atomic_write and dio
PATCH v2 1/1 f2fs: test for race condition in between atomic_write and dio
Test that we will simulate sqlite atomic write logic w/ below steps:
1. create a regular file, and initialize it w/ 0xff data
2. start transaction (via F2FS_IOC_START_ATOMIC_WRITE) on it
3. write transaction data
4. trigger direct read/write IO to check whether it fails or not
5. commit and end the transaction (via F2FS_IOC_COMMIT_ATOMIC_WRITE) This is a regression test to check handling of race condition in between atomic_write and direct IO.
---
v2:
- add kill&wait in _clean() to avoid umount failure
- some cleanups
- use exported helpler
tests/f2fs/004 | 48 ++++++++++++++++++++++++++++++++++++++++++++++ tests/f2fs/004.out | 3 +++ 2 files changed, 51 insertions(+) create mode 100755 tests/f2fs/004 create mode 100644 tests/f2fs/004.out
tests/f2fs/004 new file +48 -0
@@ -0,0 +1,48 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2024 Oppo. All Rights Reserved. +# +# FS QA Test No. f2fs/004 +# +# Test that we will simulate race case in between sqlite atomic write +# and direct IO w/ below steps: +# 1. create a regular file, and initialize it w/ 0xff data +# 2. start transaction (via F2FS_IOC_START_ATOMIC_WRITE) on it +# 3. write transaction data +# 4. trigger direct read/write IO to check whether it fails or not +# 5. commit and end the transaction (via F2FS_IOC_COMMIT_ATOMIC_WRITE) +# This is a regression test to check handling of race condition in +# between atomic_write and direct IO. +# +. ./common/preamble +_begin_fstest auto quick + +. ./common/filter + +_cleanup() +{ + kill -9 $atomic_write_pid > /dev/null 2>&1 + wait > /dev/null 2>&1 +} + +_require_scratch +_require_odirect +_scratch_mkfs >> $seqres.full +_scratch_mount >> $seqres.full + +dbfile=$SCRATCH_MNT/dbfile + +# start atomic_write on dbfile & write data to dbfile +touch $dbfile +$F2FS_IO_PROG write 1 0 32 zero atomic_commit $dbfile 3000 >> $seqres.full & +atomic_write_pid=$! + +# simulate concurrent direct read/write IO +$XFS_IO_PROG -d -c "pread 0 128k" $dbfile +$XFS_IO_PROG -d -c "pwrite 0 128k" $dbfile + +# wait for atomic_write commit completion +sleep 5 + +status=0 +exit
tests/f2fs/004.out new file +3 -0
@@ -0,0 +1,3 @@ +QA output created by 004 +pread: Operation not supported +pwrite: Operation not supported
Signature · 1 line
2.40.1
Quoted 44 lines · Chao Yu
Test that we will simulate sqlite atomic write logic w/ below steps:
1. create a regular file, and initialize it w/0xffdata
2. start transaction (viaF2FS_IOC_START_ATOMIC_WRITE) on it
3. write transaction data
4. trigger direct read/write IO to check whether it fails or not
5. commit and end the transaction (viaF2FS_IOC_COMMIT_ATOMIC_WRITE) This is a regression test to check handling of race condition in betweenatomic_writeand direct IO.Cc Jaegeuk Kim <[email protected]>Cc Daeho Jeong <[email protected]>Signed-off-by Chao Yu <[email protected]>---
v2:
- add kill&wait in_clean()to avoid umount failure
- some cleanups
- use exported helplertests/f2fs/004 | 48 ++++++++++++++++++++++++++++++++++++++++++++++ tests/f2fs/004.out | 3 +++ 2 files changed, 51 insertions(+) create mode 100755 tests/f2fs/004 create mode 100644 tests/f2fs/004.outtests/f2fs/004 new file +15
-0@@ -0,0 +1,48 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2024 Oppo. All Rights Reserved. +# +# FS QA Test No. f2fs/004 +# +# Test that we will simulate race case in between sqlite atomic write +# and direct IO w/ below steps: +# 1. create a regular file, and initialize it w/ 0xff data +# 2. start transaction (via F2FS_IOC_START_ATOMIC_WRITE) on it +# 3. write transaction data +# 4. trigger direct read/write IO to check whether it fails or not +# 5. commit and end the transaction (via F2FS_IOC_COMMIT_ATOMIC_WRITE) +# This is a regression test to check handling of race condition in +# between atomic_write and direct IO.
tests/f2fs/004 line 25
Quoted 10 lines
tests/f2fs/004 new file +10
-0+# +. ./common/preamble +_begin_fstest auto quick + +. ./common/filter + +_cleanup() +{ + kill -9 $atomic_write_pid > /dev/null 2>&1 + wait > /dev/null 2>&1
This version is good to me, same things as your last patch. I'll change it when I merge this patch.
Quoted 35 lines
tests/f2fs/004 new file +23
-0+} + +_require_scratch +_require_odirect +_scratch_mkfs >> $seqres.full +_scratch_mount >> $seqres.full + +dbfile=$SCRATCH_MNT/dbfile + +# start atomic_write on dbfile & write data to dbfile +touch $dbfile +$F2FS_IO_PROG write 1 0 32 zero atomic_commit $dbfile 3000 >> $seqres.full & +atomic_write_pid=$! + +# simulate concurrent direct read/write IO +$XFS_IO_PROG -d -c "pread 0 128k" $dbfile +$XFS_IO_PROG -d -c "pwrite 0 128k" $dbfile + +# wait for atomic_write commit completion +sleep 5 + +status=0 +exittests/f2fs/004.out new file +3
-0@@ -0,0 +1,3 @@ +QA output created by 004 +pread: Operation not supported +pwrite: Operation not supportedSignature · 1 line
2.40.1