kallsyms: unify seq and start_pos fields of struct sym_entry
PATCH 1/2 kallsyms: unify seq and start_pos fields of struct sym_entry
The struct sym_entry uses the 'seq' and 'start_pos' fields to remember the index in the symbol table. They serve the same purpose and are not used simultaneously. Unify them.
Signed-off-by Masahiro Yamada <[email protected]>
---
scripts/kallsyms.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
scripts/kallsyms.c +2 -3
@@ -36,7 +36,6 @@ struct sym_entry {unsigned long long addr;unsigned int len;unsigned int seq; -unsigned int start_pos;unsigned int percpu_absolute;unsigned char sym[]; };
@@ -278,7 +277,7 @@ static void read_map(const char *in)if (!sym)continue ; - sym->start_pos = table_cnt; + sym->seq = table_cnt;if (table_cnt >= table_size) { table_size +=10000 ;
@@ -762,7 +761,7 @@ static int compare_symbols(const void *a, const void *b)return wa - wb;/* sort by initial order, so that other symbols are left undisturbed */ -return sa->start_pos - sb->start_pos; +return sa->seq - sb->seq; }static void sort_symbols (void )
Signature · 1 line
2.43.0
PATCH 2/2 kallsyms: change sym_entry::percpu_absolute to bool type
This field is boolean.
Signed-off-by Masahiro Yamada <[email protected]>
---
scripts/kallsyms.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
scripts/kallsyms.c +4 -4
@@ -36,7 +36,7 @@ struct sym_entry {unsigned long long addr;unsigned int len;unsigned int seq; -unsigned int percpu_absolute; +bool percpu_absolute;unsigned char sym[]; };
@@ -181,7 +181,7 @@ static struct sym_entry *read_symbol(FILE *in, char **buf, size_t *buf_len) sym->len = len; sym->sym[0 ] = type;strcpy (sym_name (sym), name); - sym->percpu_absolute =0 ; + sym->percpu_absolute = false;return sym; }
@@ -339,7 +339,7 @@ static int expand_symbol(const unsigned char *data, int len, char *result)return total; } -static int symbol_absolute (const struct sym_entry *s) +static bool symbol_absolute (const struct sym_entry *s) {return s->percpu_absolute; }
@@ -781,7 +781,7 @@ static void make_percpus_absolute(void)* versions of this tool. */ table[i]->sym[0 ] ='A' ; - table[i]->percpu_absolute =1 ; + table[i]->percpu_absolute = true; } }
Signature · 1 line
2.43.0