Skip to contentSkip to conversation

kbuild: Fix broken "make binrpm-pkg"

PATCH In review Juergen Gross 2 participants 2 messages Jul 24, 2024 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kbuild: Fix broken "make binrpm-pkg"

Due to a typo "make binrpm-pkg" isn't working when using e.g. german locale. rpmbuild will tell me:

error: bad date in %changelog: Mi Jul 24 2024 Juergen Gross <[email protected]>

Reason is that setting "LC_ALL=C" must not be followed by a semicolon in order to affect the following "date" command.

Fixes 301c10908e42 ("kbuild: rpm-pkg: introduce a simple changelog section for kernel.spec")
---
 scripts/package/mkspec | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/package/mkspec +1 -1
index ead54d67a024..4dc1466dfc81 100755
@@ -50,6 +50,6 @@ fi
 cat << EOF
 
 %changelog
-* $(LC_ALL=C; date +'%a %b %d %Y') ${name} <${email}>
+* $(LC_ALL=C date +'%a %b %d %Y') ${name} <${email}>
 - Custom built Linux kernel.
 EOF
Signature · 1 line
2.43.0
#1 lore raw
Quoted 28 lines · Juergen Gross

Due to a typo "make binrpm-pkg" isn't working when using e.g. german locale. rpmbuild will tell me:

error: bad date in %changelog: Mi Jul 24 2024 Juergen Gross <[email protected]>

Reason is that setting "LC_ALL=C" must not be followed by a semicolon in order to affect the following "date" command.

Fixes 301c10908e42 ("kbuild: rpm-pkg: introduce a simple changelog section for kernel.spec")
---
 scripts/package/mkspec | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/package/mkspec +1 -2
index ead54d67a024..4dc1466dfc81 100755
@@ -50,6 +50,6 @@ fi
 cat << EOF
 
 %changelog
-* $(LC_ALL=C; date +'%a %b %d %Y') ${name} <${email}>
+* $(LC_ALL=C date +'%a %b %d %Y') ${name} <${email}>
 - Custom built Linux kernel.
 EOF
--
Quoted 3 lines

2.43.0

Fixed in kbuild.git#fixes

https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git/log/?h=fixes
https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git/commit/?h=fixes&id=ba6c664081afd18da86ac49cb22ceb266f89a561

-Sedat-