Skip to contentSkip to conversation

selftests: mm: add s390 to ARCH check

PATCH Superseded Nico Pache 2 participants 2 messages Jul 24, 2024

Subsystems (4)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Nico Pache

author
#0 lore raw

PATCH 1/1 selftests: mm: add s390 to ARCH check

When compiling with ARCH already set, the s390x ARCH is actually s390. Add s390 to the ARCH check list, so we can properly build selftests for s390.

---
 tools/testing/selftests/mm/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/mm/Makefile +1 -1
index 901e0d07765b..7b8a5def54a1 100644
@@ -110,7 +110,7 @@ endif
 
 endif
 
-ifneq (,$(filter $(ARCH),arm64 ia64 mips64 parisc64 powerpc riscv64 s390x sparc64 x86_64))
+ifneq (,$(filter $(ARCH),arm64 ia64 mips64 parisc64 powerpc riscv64 s390x sparc64 x86_64 s390))
 TEST_GEN_FILES += va_high_addr_switch
 TEST_GEN_FILES += virtual_address_range
 TEST_GEN_FILES += write_to_hugetlbfs
Signature · 1 line
2.45.2
maintainer
#1 lore raw
Quoted 4 lines · On Wed, 24 Jul 2024 14:09:55 -0600 Nico Pache <[email protected]> wrote:

When compiling with ARCH already set, the s390x ARCH is actually s390. Add s390 to the ARCH check list, so we can properly build selftests for s390.

Unclear what "properly" means. I assume it partially works?

I'm assuming that properly building selftests for s390 is desirable, so a cc:stable is needed? Is there a suitable Fixes:?

I'd really prefer not to assume! A more detailed changelog which describes the problem would be helpful, thanks.