Skip to contentSkip to conversation

um-mm-remove-redundant-assignment-of-max_low_pfn.patch removed from -mm tree

merged Andrew Morton 1 participant 1 message Jul 25, 2024

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: um/mm: remove redundant assignment of max_low_pfn
has been removed from the -mm tree. Its filename was
um-mm-remove-redundant-assignment-of-max_low_pfn.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: Wei Yang <[email protected]>
Subject: um/mm: remove redundant assignment of max_low_pfn
Date: Sat, 15 Jun 2024 03:41:50 +0000

Current calculation of max_low_pfn is introduced in commit af84eab20891 ("[PATCH] uml: fix LVM crash"). It is intended to set max_low_pfn to the same value as max_pfn.

But I am not sure why the max_pfn is set to totalram_pages, which represents the number of usable pages in system instead of an absolute page frame number. (The change history stops there.)

While we have already calculate it in setup_physmem(), so not necessary to do it again.

Also this would help changing totalram_pages accounting, since we plan to move the accounting into __free_pages_core(). With this change, totalram_pages may not represent the total usable pages at this point, since some pages would be deferred initialized.

---

 arch/um/kernel/mem.c |    1 -
 1 file changed, 1 deletion(-)
arch/um/kernel/mem.c renamed from arch/um/kernel/mem.c~um-mm-remove-redundant-assignment-of-max_low_pfn +0 -1
@@ -73,7 +73,6 @@ void __init mem_init(void)
 
 	/* this will put all low memory onto the freelists */
 	memblock_free_all();
-	max_low_pfn = totalram_pages();
 	max_pfn = max_low_pfn;
 	kmalloc_ok = 1;
 }

_

Patches currently in -mm which might be from [email protected] are