hfsplus: Initialize directory subfolders in hfsplus_mknod

PATCH Siddharth Menon 1 participant 1 message Jul 27, 2024

Subsystems (2)

VFS Hfsplus filesystem

lore

Share & tools

lore

Siddharth Menon

author

2024-07-27 05:05 UTC #0 lore raw

hfsplus: Initialize directory subfolders in hfsplus_mknod

Addresses uninitialized subfolders attribute being used in hfsplus_subfolders_inc and hfsplus_subfolders_dec.

Fixes https://syzkaller.appspot.com/bug?extid=fdedff847a0e5e84c39f

Reported-by [email protected]

Closes https://syzkaller.appspot.com/x/report.txt?x=16efda06680000

Signed-off-by Siddharth Menon <[email protected]>

---
 fs/hfsplus/dir.c | 3 +++
 1 file changed, 3 insertions(+)

fs/hfsplus/dir.c +3 -0

index f5c4b3e31a1c..331c4118bc8e 100644
@@ -485,6 +485,9 @@ static int hfsplus_mknod(struct mnt_idmap *idmap, struct inode *dir,
 
 	mutex_lock(&sbi->vh_mutex);
 	inode = hfsplus_new_inode(dir->i_sb, dir, mode);
+	if (test_bit(HFSPLUS_SB_HFSX, &sbi->flags))
+		HFSPLUS_I(dir)->subfolders = 0;
+
 	if (!inode)
 		goto out;

Signature · 1 line

2.39.2