Skip to contentSkip to conversation

device-parts: editorial: Add missing struct keyword

PATCH In review Parav Pandit 1 participant 4 messages Jul 29, 2024 – Sep 5, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 device-parts: editorial: Add missing struct keyword

'struct' keyword was missing in the definition.
Add it.

Branch: virtio-1.4

Fixes aa4f6f06 ("admin: Add admin commands for device parts")
---
 admin-cmds-device-parts.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
admin-cmds-device-parts.tex +1 -1
index 4c88045..27d8251 100644
@@ -131,7 +131,7 @@ \subsubsection{Device parts}\label{sec:Basic Facilities of a Virtio Device / Dev
                         le32 count;
                         le32 reserved;
                 } hdr_list_count;
-                {
+                struct {
                         le32 count;
                         le32 reserved;
                         struct virtio_dev_part_hdr hdrs[];
Signature · 1 line
2.34.1
#1 lore raw

Hi Michael, Cornelia,

Quoted 7 lines

-----Original Message-----
From: Parav Pandit <[email protected]>
Sent: Monday, July 29, 2024 2:50 PM
To: [email protected]; [email protected]; [email protected]
Cc: Shahaf Shuler <[email protected]>; Parav Pandit <[email protected]>
Subject: [PATCH] device-parts: editorial: Add missing struct keyword

Quoted 6 lines

'struct' keyword was missing in the definition.
Add it.

Branch: virtio-1.4

Fixes aa4f6f06 ("admin: Add admin commands for device parts")

Can you please take this fix for the 1.4 branch?

Quoted 20 lines
---
 admin-cmds-device-parts.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
admin-cmds-device-parts.tex index renamed from admin-cmds-device-parts.tex +0 -0

4c88045..27d8251 100644

admin-cmds-device-parts.tex +0 -0
@@ -131,7 +131,7 @@ \subsubsection{Device parts}\label{sec:Basic Facilities

of a Virtio Device / Dev

                         le32 count;
                         le32 reserved;
                 } hdr_list_count;
admin-cmds-device-parts.tex +1 -2
-                {
+                struct {
                         le32 count;
                         le32 reserved;
                         struct virtio_dev_part_hdr hdrs[];
--

2.34.1

#2 lore raw

Hi Michael,

Quoted 7 lines

-----Original Message-----
From: Parav Pandit <[email protected]>
Sent: Sunday, August 11, 2024 5:48 PM
To: [email protected]; [email protected]; [email protected]
Cc: Shahaf Shuler <[email protected]>
Subject: RE: [PATCH] device-parts: editorial: Add missing struct keyword

Quoted 5 lines

Hi Michael, Cornelia,

Quoted 3 lines

-----Original Message-----
From: Parav Pandit <[email protected]>
Sent: Monday, July 29, 2024 2:50 PM

Can you please take this fix for 1.4 branch?

Quoted 37 lines
Quoted 1 line

To: [email protected]; [email protected];

[email protected]

Quoted 10 lines

Cc: Shahaf Shuler <[email protected]>; Parav Pandit <[email protected]>
Subject: [PATCH] device-parts: editorial: Add missing struct keyword

'struct' keyword was missing in the definition.
Add it.

Branch: virtio-1.4

Fixes aa4f6f06 ("admin: Add admin commands for device parts")

Can you please take this fix for the 1.4 branch?

Quoted 21 lines
---
 admin-cmds-device-parts.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
admin-cmds-device-parts.tex +0 -0

index
4c88045..27d8251 100644

admin-cmds-device-parts.tex +0 -0
@@ -131,7 +131,7 @@ \subsubsection{Device parts}\label{sec:Basic

Facilities of a Virtio Device / Dev

                         le32 count;
                         le32 reserved;
                 } hdr_list_count;
admin-cmds-device-parts.tex +1 -2
-                {
+                struct {
                         le32 count;
                         le32 reserved;
                         struct virtio_dev_part_hdr hdrs[];
--

2.34.1

#3 lore raw

Hi Michael, Cornelia,

Quoted 14 lines

From: Parav Pandit <[email protected]>
Sent: Saturday, August 17, 2024 10:50 AM

Hi Michael,

Quoted 4 lines

-----Original Message-----
From: Parav Pandit <[email protected]>
Sent: Sunday, August 11, 2024 5:48 PM
To: [email protected]; [email protected];

[email protected]

Quoted 4 lines

Cc: Shahaf Shuler <[email protected]>
Subject: RE: [PATCH] device-parts: editorial: Add missing struct keyword

Quoted 8 lines
Quoted 5 lines

Hi Michael, Cornelia,

Quoted 3 lines

-----Original Message-----
From: Parav Pandit <[email protected]>
Sent: Monday, July 29, 2024 2:50 PM

Can you please take this fix for 1.4 branch?

Can you please take this fix for 1.4 branch?
This has been up for review for last 5+ weeks!

Quoted 37 lines
Quoted 37 lines
Quoted 1 line

To: [email protected]; [email protected];

[email protected]

Quoted 10 lines

Cc: Shahaf Shuler <[email protected]>; Parav Pandit <[email protected]>
Subject: [PATCH] device-parts: editorial: Add missing struct keyword

'struct' keyword was missing in the definition.
Add it.

Branch: virtio-1.4

Fixes aa4f6f06 ("admin: Add admin commands for device parts")

Can you please take this fix for the 1.4 branch?

Quoted 21 lines
---
 admin-cmds-device-parts.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/admin-cmds-device-parts.tex index
4c88045..27d8251 100644

admin-cmds-device-parts.tex +0 -0
@@ -131,7 +131,7 @@ \subsubsection{Device parts}\label{sec:Basic

Facilities of a Virtio Device / Dev

                         le32 count;
                         le32 reserved;
                 } hdr_list_count;
admin-cmds-device-parts.tex +1 -2
-                {
+                struct {
                         le32 count;
                         le32 reserved;
                         struct virtio_dev_part_hdr hdrs[];
--

2.34.1