FAILED: patch "[PATCH] dmaengine: fsl-edma: change the memory access from local into" failed to apply to 6.6-stable tree
Subsystems (3)
[email protected]
maintainerThe patch below does not apply to the 6.6-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.6.y
git checkout FETCH_HEAD
git cherry-pick -x 8ddad558997002ce67980e30c9e8dfaa696e163b
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2024072928-engaged-steerable-531f@gregkh' --subject-prefix 'PATCH 6.6.y' HEAD^..
Possible dependencies:
8ddad5589970 ("dmaengine: fsl-edma: change the memory access from local into remote mode in i.MX 8QM") 77584368a0f3 ("dmaengine: fsl-edma: clean up unused "fsl,imx8qm-adma" compatible string") d8d4355861d8 ("dmaengine: fsl-edma: add i.MX8ULP edma support")4ee632c82d2d ("dmaengine: fsl-edma: fix DMA channel leak in eDMAv4")
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 8ddad558997002ce67980e30c9e8dfaa696e163b Mon Sep 17 00:00:00 2001
From: Joy Zou <[email protected]>
Date: Fri, 10 May 2024 11:09:34 +0800
Subject: [PATCH] dmaengine: fsl-edma: change the memory access from local into
remote mode in i.MX 8QM
Fix the issue where MEM_TO_MEM fail on i.MX8QM due to the requirement that both source and destination addresses need pass through the IOMMU. Typically, peripheral FIFO addresses bypass the IOMMU, necessitating only one of the source or destination to go through it.
Set "is_remote" to true to ensure both source and destination addresses pass through the IOMMU.
iMX8 Spec define "Local" and "Remote" bus as below.
Local bus: bypass IOMMU to directly access other peripheral register, such as FIFO.
Remote bus: go through IOMMU to access system memory.
The test fail log as follow:
[ 66.268506] dmatest: dma0chan0-copy0: result #1: 'test timed out' with src_off=0x100 dst_off=0x80 len=0x3ec0 (0) [ 66.278785] dmatest: dma0chan0-copy0: summary 1 tests, 1 failures 0.32 iops 4 KB/s (0)
drivers/dma/fsl-edma-common.c +3 -0
@@ -755,6 +755,8 @@ struct dma_async_tx_descriptor *fsl_edma_prep_memcpy(struct dma_chan *chan, fsl_desc->iscyclic = false; fsl_chan->is_sw = true; +if (fsl_edma_drvflags (fsl_chan) &FSL_EDMA_DRV_MEM_REMOTE ) + fsl_chan->is_remote = true;/* To match with copy_align and max_seg_size so 1 tcd is enough */ fsl_edma_fill_tcd(fsl_chan, fsl_desc->tcd[0].vtcd, dma_src, dma_dst,
@@ -848,6 +850,7 @@ void fsl_edma_free_chan_resources(struct dma_chan *chan) fsl_chan->tcd_pool =NULL ; fsl_chan->is_sw = false; fsl_chan->srcid =0 ; + fsl_chan->is_remote = false;if (fsl_edma_drvflags (fsl_chan) &FSL_EDMA_DRV_HAS_CHCLK )clk_disable_unprepare (fsl_chan->clk); }
drivers/dma/fsl-edma-common.h +1 -0
@@ -194,6 +194,7 @@ struct fsl_edma_desc {#define FSL_EDMA_DRV_HAS_PD BIT(5)#define FSL_EDMA_DRV_HAS_CHCLK BIT(6)#define FSL_EDMA_DRV_HAS_CHMUX BIT(7) +#define FSL_EDMA_DRV_MEM_REMOTE BIT(8)/* control and status register is in tcd address space, edma3 reg layout */ #define FSL_EDMA_DRV_SPLIT_REG BIT(9)#define FSL_EDMA_DRV_BUS_8BYTE BIT(10)
drivers/dma/fsl-edma-main.c +1 -1
@@ -343,7 +343,7 @@ static struct fsl_edma_drvdata imx7ulp_data = { };static struct fsl_edma_drvdata imx8qm_data = { - .flags =FSL_EDMA_DRV_HAS_PD |FSL_EDMA_DRV_EDMA3 , + .flags =FSL_EDMA_DRV_HAS_PD |FSL_EDMA_DRV_EDMA3 |FSL_EDMA_DRV_MEM_REMOTE , .chreg_space_sz =0x10000 , .chreg_off =0x10000 , .setup_irq = fsl_edma3_irq_init,