FAILED: patch "[PATCH] mtd: rawnand: lpx32xx: Fix dma_request_chan() error checks" failed to apply to 5.4-stable tree
[email protected]
maintainerThe patch below does not apply to the 5.4-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.4.y
git checkout FETCH_HEAD
git cherry-pick -x a503f91a3645651a39baf97f1aed90d5d9f9bda9
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2024073000-cedar-nutrient-4b9a@gregkh' --subject-prefix 'PATCH 5.4.y' HEAD^..
Possible dependencies:
a503f91a3645 ("mtd: rawnand: lpx32xx: Fix dma_request_chan() error checks") 478211867460 ("mtd: rawnand: lpx32xx: Request DMA channels using DT entries")
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From a503f91a3645651a39baf97f1aed90d5d9f9bda9 Mon Sep 17 00:00:00 2001
From: Piotr Wojtaszczyk <[email protected]>
Date: Fri, 5 Jul 2024 13:51:35 +0200
Subject: [PATCH] mtd: rawnand: lpx32xx: Fix dma_request_chan() error checks
The dma_request_chan() returns error pointer in case of error, while dma_request_channel() returns NULL in case of error therefore different error checks are needed for the two.
drivers/mtd/nand/raw/lpc32xx_mlc.c +1 -1
@@ -575,7 +575,7 @@ static int lpc32xx_dma_setup(struct lpc32xx_nand_host *host)dma_cap_mask_t mask; host->dma_chan =dma_request_chan (mtd->dev.parent,"rx-tx" ); -if (!host->dma_chan) { +if (IS_ERR (host->dma_chan)) {/* fallback to request using platform data */ if (!host->pdata || !host->pdata->dma_filter) {dev_err (mtd->dev.parent,"no DMA platform data\n" );
drivers/mtd/nand/raw/lpc32xx_slc.c +1 -1
@@ -722,7 +722,7 @@ static int lpc32xx_nand_dma_setup(struct lpc32xx_nand_host *host)dma_cap_mask_t mask; host->dma_chan =dma_request_chan (mtd->dev.parent,"rx-tx" ); -if (!host->dma_chan) { +if (IS_ERR (host->dma_chan)) {/* fallback to request using platform data */ if (!host->pdata || !host->pdata->dma_filter) {dev_err (mtd->dev.parent,"no DMA platform data\n" );