firmware: qcom: tzmem: disable sdm670 platform
PATCH 1/1 firmware: qcom: tzmem: disable sdm670 platform
The Pixel 3a returns 4291821499 (-3145797 or 0xFFCFFFBB) when attempting to load the GPU firmware if tzmem is allowed. Disable it on SDM670 so the GPU can successfully probe.
--- drivers/firmware/qcom/qcom_tzmem.c | 1 + 1 file changed, 1 insertion(+)
drivers/firmware/qcom/qcom_tzmem.c +1 -0
@@ -78,6 +78,7 @@ static bool qcom_tzmem_using_shm_bridge;/* List of machines that are known to not support SHM bridge correctly. */ static const char *const qcom_tzmem_blacklist[] = {"qcom,sc8180x" , +"qcom,sdm670" ,/* failure in GPU firmware loading */ "qcom,sdm845" ,/* reset in rmtfs memory assignment */ "qcom,sm8150" ,/* reset in rmtfs memory assignment */ NULL
Signature · 1 line
2.45.2
Quoted 23 lines · Richard Acayan
The Pixel 3a returns 4291821499 (-3145797 or
0xFFCFFFBB) when attempting to load the GPU firmware if tzmem is allowed. Disable it on SDM670 so the GPU can successfully probe.Signed-off-by Richard Acayan <[email protected]>--- drivers/firmware/qcom/qcom_tzmem.c | 1 + 1 file changed, 1 insertion(+)drivers/firmware/qcom/qcom_tzmem.c +1
-1@@ -78,6 +78,7 @@ static bool qcom_tzmem_using_shm_bridge;/* List of machines that are known to not support SHM bridge correctly. */ static const char *const qcom_tzmem_blacklist[] = {"qcom,sc8180x" , +"qcom,sdm670" ,/* failure in GPU firmware loading */ "qcom,sdm845" ,/* reset in rmtfs memory assignment */ "qcom,sm8150" ,/* reset in rmtfs memory assignment */ NULL --
Quoted 3 lines
2.45.2
Ugh... As the list is growing post mainline merge I'm wondering whether we should make the generic allocator the default in defconfig and SHM Bridge an opt-in option?
Bartosz
Bjorn Andersson
maintainerQuoted 23 lines · Bartosz Golaszewski
Quoted 22 lines · Richard Acayan
The Pixel 3a returns 4291821499 (-3145797 or
0xFFCFFFBB) when attempting to load the GPU firmware if tzmem is allowed. Disable it on SDM670 so the GPU can successfully probe.Signed-off-by Richard Acayan <[email protected]>--- drivers/firmware/qcom/qcom_tzmem.c | 1 + 1 file changed, 1 insertion(+)drivers/firmware/qcom/qcom_tzmem.c +1
-0@@ -78,6 +78,7 @@ static bool qcom_tzmem_using_shm_bridge;/* List of machines that are known to not support SHM bridge correctly. */ static const char *const qcom_tzmem_blacklist[] = {"qcom,sc8180x" , +"qcom,sdm670" ,/* failure in GPU firmware loading */ "qcom,sdm845" ,/* reset in rmtfs memory assignment */ "qcom,sm8150" ,/* reset in rmtfs memory assignment */ NULL
Quoted 9 lines
Quoted 4 lines
--
2.45.2Ugh... As the list is growing post mainline merge I'm wondering whether we should make the generic allocator the default in defconfig and SHM Bridge an opt-in option?
Can you confirm that we still need this, and the other entries in this list?
Thanks,
Bjorn
Bartosz Golaszewski
Acked-byQuoted 35 lines · Bjorn Andersson
Quoted 23 lines · Bartosz Golaszewski
Quoted 22 lines · Richard Acayan
The Pixel 3a returns 4291821499 (-3145797 or
0xFFCFFFBB) when attempting to load the GPU firmware if tzmem is allowed. Disable it on SDM670 so the GPU can successfully probe.Signed-off-by Richard Acayan <[email protected]>--- drivers/firmware/qcom/qcom_tzmem.c | 1 + 1 file changed, 1 insertion(+)drivers/firmware/qcom/qcom_tzmem.c +1
-0@@ -78,6 +78,7 @@ static bool qcom_tzmem_using_shm_bridge;/* List of machines that are known to not support SHM bridge correctly. */ static const char *const qcom_tzmem_blacklist[] = {"qcom,sc8180x" , +"qcom,sdm670" ,/* failure in GPU firmware loading */ "qcom,sdm845" ,/* reset in rmtfs memory assignment */ "qcom,sm8150" ,/* reset in rmtfs memory assignment */ NULL Quoted 9 lines
Quoted 4 lines
--
2.45.2Ugh... As the list is growing post mainline merge I'm wondering whether we should make the generic allocator the default in defconfig and SHM Bridge an opt-in option?
Quoted 5 lines
Can you confirm that we still need this, and the other entries in this list?
Thanks,
Bjorn
Yes, the fix you picked up was for a different bug. I'm in touch with Qualcomm about debugging the firmware here but it's not going to be immediate so let's apply this for now.
Bart
Quoted 5 lines · Richard Acayan
The Pixel 3a returns 4291821499 (-3145797 or
0xFFCFFFBB) when attempting to load the GPU firmware if tzmem is allowed. Disable it on SDM670 so the GPU can successfully probe.
Applied, thanks!
[1/1] firmware: qcom: tzmem: disable sdm670 platform
commit: 8342009efa2a5e75dce56173d7de026bcc6666d8
Best regards,
Signature · 1 line
Bjorn Andersson <[email protected]>