Skip to contentSkip to conversation

staging: rtl8192e: remove duplicate macros from rtllib.h

PATCH In review Michael Straube 2 participants 2 messages Jul 30, 2024 – Jul 31, 2024 Staging

lore
Share & tools
lore

Michael Straube

author
#0 lore raw

PATCH 1/1 staging: rtl8192e: remove duplicate macros from rtllib.h

These macros just duplicate macros from include/linux/ieee80211.h. We can safely remove them from rtllib.h.

Signed-off-by Michael Straube <[email protected]>

---
compile-tested only

 drivers/staging/rtl8192e/rtllib.h | 11 -----------
 1 file changed, 11 deletions(-)
drivers/staging/rtl8192e/rtllib.h +0 -11
index 022851b7f1a9..e87313a30741 100644
@@ -414,17 +414,6 @@ enum _REG_PREAMBLE_MODE {
 #define WLAN_GET_SEQ_FRAG(seq) ((seq) & RTLLIB_SCTL_FRAG)
 #define WLAN_GET_SEQ_SEQ(seq)  (((seq) & RTLLIB_SCTL_SEQ) >> 4)
 
-/* Authentication algorithms */
-#define WLAN_AUTH_OPEN 0
-#define WLAN_AUTH_SHARED_KEY 1
-#define WLAN_AUTH_LEAP 128
-
-#define WLAN_CAPABILITY_ESS (1<<0)
-#define WLAN_CAPABILITY_IBSS (1<<1)
-#define WLAN_CAPABILITY_PRIVACY (1<<4)
-#define WLAN_CAPABILITY_SHORT_PREAMBLE (1<<5)
-#define WLAN_CAPABILITY_SHORT_SLOT_TIME (1<<10)
-
 #define RTLLIB_STATMASK_SIGNAL (1<<0)
 #define RTLLIB_STATMASK_RSSI (1<<1)
 #define RTLLIB_STATMASK_NOISE (1<<2)
Signature · 1 line
2.45.2
Tested-by on v1 1/1
#1 lore raw
Quoted 22 lines · Michael Straube

These macros just duplicate macros from include/linux/ieee80211.h. We can safely remove them from rtllib.h.

Signed-off-by Michael Straube <[email protected]>

---
compile-tested only

  drivers/staging/rtl8192e/rtllib.h | 11 -----------
  1 file changed, 11 deletions(-)
drivers/staging/rtl8192e/rtllib.h +0 -4
index 022851b7f1a9..e87313a30741 100644
@@ -414,17 +414,6 @@ enum _REG_PREAMBLE_MODE {
  #define WLAN_GET_SEQ_FRAG(seq) ((seq) & RTLLIB_SCTL_FRAG)
  #define WLAN_GET_SEQ_SEQ(seq)  (((seq) & RTLLIB_SCTL_SEQ) >> 4)
 
-/* Authentication algorithms */
-#define WLAN_AUTH_OPEN 0
-#define WLAN_AUTH_SHARED_KEY 1
-#define WLAN_AUTH_LEAP 128

drivers/staging/rtl8192e/rtllib.h enum _REG_PREAMBLE_MODE { · line 419

Quoted 10 lines
drivers/staging/rtl8192e/rtllib.h +0 -7
-
-#define WLAN_CAPABILITY_ESS (1<<0)
-#define WLAN_CAPABILITY_IBSS (1<<1)
-#define WLAN_CAPABILITY_PRIVACY (1<<4)
-#define WLAN_CAPABILITY_SHORT_PREAMBLE (1<<5)
-#define WLAN_CAPABILITY_SHORT_SLOT_TIME (1<<10)
-
  #define RTLLIB_STATMASK_SIGNAL (1<<0)
  #define RTLLIB_STATMASK_RSSI (1<<1)
  #define RTLLIB_STATMASK_NOISE (1<<2)
Tested-by Philipp Hortmann <[email protected]>