Skip to contentSkip to conversation

USB: serial: kobil_sct: restore initial terminal settings

PATCH New Johan Hovold 1 participant 1 message Jul 31, 2024

Subsystems (2)
USB USB serial
lore
Share & tools
lore

Johan Hovold

author maintainer
#0 lore raw

PATCH 1/1 USB: serial: kobil_sct: restore initial terminal settings

Commit 6a6c8b362be3 ("usb, kobil: Sort out some bogus tty handling") intended to fix and clean up the device-specific initial terminal settings but instead confused the termios input and local control flags and re-enabled ICRNL and IXON.

Drop the bogus masking of l-flags from the default i-flags (which has no effect) and restore the original device-specific i-flags.

Fixes 6a6c8b362be3 ("usb, kobil: Sort out some bogus tty handling")
Signed-off-by Johan Hovold <[email protected]>
---
 drivers/usb/serial/kobil_sct.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/usb/serial/kobil_sct.c +1 -2
index 5eb59ac3e564..464433be2034 100644
@@ -155,8 +155,7 @@ static void kobil_init_termios(struct tty_struct *tty)
 {
 	/* Default to echo off and other sane device settings */
 	tty->termios.c_lflag = 0;
-	tty->termios.c_iflag &= ~(ISIG | ICANON | ECHO | IEXTEN | XCASE);
-	tty->termios.c_iflag |= IGNBRK | IGNPAR | IXOFF;
+	tty->termios.c_iflag = IGNBRK | IGNPAR | IXOFF;
 	/* do NOT translate CR to CR-NL (0x0A -> 0x0A 0x0D) */
 	tty->termios.c_oflag &= ~ONLCR;
 }
Signature · 1 line
2.44.2