Skip to contentSkip to conversation

bus: ti-sysc: Use of_property_present()

PATCH Applied Rob Herring (Arm) 3 participants 5 messages Jul 31, 2024 – Aug 6, 2024 OMAP2+ support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bus: ti-sysc: Use of_property_present()

Use of_property_present() to test for property presence rather than of_get_property(). This is part of a larger effort to remove callers of of_get_property() and similar functions. of_get_property() leaks the DT property data pointer which is a problem for dynamically allocated nodes which may be freed.

The code was also incorrectly assigning the return value to a 'struct property' pointer. It didn't matter as "prop" was never dereferenced.

---
 drivers/bus/ti-sysc.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/bus/ti-sysc.c +2 -4
index 2b59ef61dda2..7caaf89f3bf2 100644
@@ -2569,14 +2569,12 @@ static const struct sysc_dts_quirk sysc_dts_quirks[] = {
 static void sysc_parse_dts_quirks(struct sysc *ddata, struct device_node *np,
 				  bool is_child)
 {
-	const struct property *prop;
-	int i, len;
+	int i;
 
 	for (i = 0; i < ARRAY_SIZE(sysc_dts_quirks); i++) {
 		const char *name = sysc_dts_quirks[i].name;
 
-		prop = of_get_property(np, name, &len);
-		if (!prop)
+		if (!of_property_present(np, name))
 			continue;
 
 		ddata->cfg.quirks |= sysc_dts_quirks[i].mask;
Signature · 1 line
2.43.0
maintainer
#1 lore raw
Quoted 10 lines · Rob Herring (Arm)

Use of_property_present() to test for property presence rather than of_get_property(). This is part of a larger effort to remove callers of of_get_property() and similar functions. of_get_property() leaks the DT property data pointer which is a problem for dynamically allocated nodes which may be freed.

The code was also incorrectly assigning the return value to a 'struct property' pointer. It didn't matter as "prop" was never dereferenced.

Reviewed by: Roger Quadros <[email protected]>

maintainer
#2 lore raw

Hi Roger,

Quoted 7 lines · Roger Quadros
Quoted 6 lines · Rob Herring (Arm)

Use of_property_present() to test for property presence rather than of_get_property(). This is part of a larger effort to remove callers of of_get_property() and similar functions. of_get_property() leaks the DT property data pointer which is a problem for dynamically allocated nodes which may be freed.

Quoted 6 lines
Quoted 4 lines

The code was also incorrectly assigning the return value to a 'struct property' pointer. It didn't matter as "prop" was never dereferenced.

Reviewed by: Roger Quadros <[email protected]>

just FYI, missing a '-' in your Reviewed-by, which means tools like b4 will not spot it. I added it manually this time cuz I happened to notice it was missing.

Kevin

maintainer
#3 lore raw

Hi Kevin,

Quoted 14 lines · Kevin Hilman

Hi Roger,

Quoted 10 lines · Roger Quadros
Quoted 9 lines · Rob Herring (Arm)

Use of_property_present() to test for property presence rather than of_get_property(). This is part of a larger effort to remove callers of of_get_property() and similar functions. of_get_property() leaks the DT property data pointer which is a problem for dynamically allocated nodes which may be freed.

The code was also incorrectly assigning the return value to a 'struct property' pointer. It didn't matter as "prop" was never dereferenced.

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

Reviewed by: Roger Quadros <[email protected]>

just FYI, missing a '-' in your Reviewed-by, which means tools like b4 will not spot it. I added it manually this time cuz I happened to notice it was missing.

Sorry, my bad. Thanks for fixing this up.

Signature · 2 lines
cheers,
-roger
maintainer Applied
#4 lore raw
In reply to Rob Herring (Arm)
Quoted 10 lines · Rob Herring (Arm)

Use of_property_present() to test for property presence rather than of_get_property(). This is part of a larger effort to remove callers of of_get_property() and similar functions. of_get_property() leaks the DT property data pointer which is a problem for dynamically allocated nodes which may be freed.

The code was also incorrectly assigning the return value to a 'struct property' pointer. It didn't matter as "prop" was never dereferenced.

[...]

Applied, thanks!

[1/1] bus: ti-sysc: Use of_property_present()

      commit: 0070dc29c85f0859a6071844b88fca6bce2974e4

Best regards,

Signature · 1 line
Kevin Hilman <[email protected]>