pinctrl: samsung: Use of_property_present()
Subsystems (4)
PATCH 1/1 pinctrl: samsung: Use of_property_present()
Use of_property_present() to test for property presence rather than of_find_property(). This is part of a larger effort to remove callers of of_find_property() and similar functions. of_find_property() leaks the DT struct property and data pointers which is a problem for dynamically allocated nodes which may be freed.
--- drivers/pinctrl/samsung/pinctrl-samsung.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/pinctrl/samsung/pinctrl-samsung.c +4 -4
@@ -823,16 +823,16 @@ static struct samsung_pmx_func *samsung_pinctrl_create_functions(struct device_node *func_np;if (!of_get_child_count (cfg_np)) { -if (!of_find_property (cfg_np, -"samsung,pin-function" ,NULL )) +if (!of_property_present (cfg_np, +"samsung,pin-function" ))continue ; ++func_cnt;continue ; }for_each_child_of_node (cfg_np, func_np) { -if (!of_find_property (func_np, -"samsung,pin-function" ,NULL )) +if (!of_property_present (func_np, +"samsung,pin-function" ))continue ; ++func_cnt; }
Signature · 1 line
2.43.0
Krzysztof Kozlowski
AppliedQuoted 8 lines · Rob Herring (Arm)
Use
of_property_present()to test for property presence rather thanof_find_property(). This is part of a larger effort to remove callers ofof_find_property()and similar functions.of_find_property()leaks the DT struct property and data pointers which is a problem for dynamically allocated nodes which may be freed.[...]
Applied, thanks!
[1/1] pinctrl: samsung: Use of_property_present()
https://git.kernel.org/pinctrl/samsung/c/aa85d45338692e8b29b0c023826c404c3e7113a6
Best regards,
Signature · 1 line
Krzysztof Kozlowski <[email protected]>