cpufreq: Use of_property_present()
Subsystems (5)
PATCH 1/1 cpufreq: Use of_property_present()
Use of_property_present() to test for property presence rather than of_(find|get)_property(). This is part of a larger effort to remove callers of of_find_property() and similar functions. of_find_property() leaks the DT struct property and data pointers which is a problem for dynamically allocated nodes which may be freed.
--- drivers/cpufreq/cpufreq-dt.c | 11 +++-------- drivers/cpufreq/pmac64-cpufreq.c | 2 +- drivers/cpufreq/sti-cpufreq.c | 2 +- drivers/cpufreq/sun50i-cpufreq-nvmem.c | 2 +- 4 files changed, 6 insertions(+), 11 deletions(-)
drivers/cpufreq/cpufreq-dt.c +3 -8
@@ -69,7 +69,6 @@ static int set_target(struct cpufreq_policy *policy, unsigned int index)static const char *find_supply_name (struct device *dev) { struct device_node *np __free(device_node) = of_node_get(dev->of_node); -struct property *pp;int cpu = dev->id;/* This must be valid for sure */
@@ -77,14 +76,10 @@ static const char *find_supply_name(struct device *dev)return NULL ;/* Try "cpu0" for older DTs */ -if (!cpu) { - pp =of_find_property (np,"cpu0-supply" ,NULL ); -if (pp) -return "cpu0" ; - } +if (!cpu &&of_property_present (np,"cpu0-supply" )) +return "cpu0" ; - pp =of_find_property (np,"cpu-supply" ,NULL ); -if (pp) +if (of_property_present (np,"cpu-supply" ))return "cpu" ;dev_dbg (dev,"no regulator for cpu%d\n" , cpu);
drivers/cpufreq/pmac64-cpufreq.c +1 -1
@@ -505,7 +505,7 @@ static int __init g5_pm72_cpufreq_init(struct device_node *cpunode)continue ;if (strcmp (loc,"CPU CLOCK" ))continue ; -if (!of_get_property (hwclock,"platform-get-frequency" ,NULL )) +if (!of_property_present (hwclock,"platform-get-frequency" ))continue ;break ; }
drivers/cpufreq/sti-cpufreq.c +1 -1
@@ -267,7 +267,7 @@ static int __init sti_cpufreq_init(void) goto skip_voltage_scaling; } -if (!of_get_property (ddata.cpu->of_node,"operating-points-v2" ,NULL )) { +if (!of_property_present (ddata.cpu->of_node,"operating-points-v2" )) {dev_err (ddata.cpu,"OPP-v2 not supported\n" ); goto skip_voltage_scaling; }
drivers/cpufreq/sun50i-cpufreq-nvmem.c +1 -1
@@ -146,7 +146,7 @@ static bool dt_has_supported_hw(void)return false;for_each_child_of_node_scoped (np, opp) { -if (of_find_property (opp,"opp-supported-hw" ,NULL )) { +if (of_property_present (opp,"opp-supported-hw" )) { has_opp_supported_hw = true;break ; }
Signature · 1 line
2.43.0
Quoted 7 lines · Rob Herring (Arm)
Use
of_property_present()to test for property presence rather than of_(find|get)_property(). This is part of a larger effort to remove callers ofof_find_property()and similar functions.of_find_property()leaks the DT struct property and data pointers which is a problem for dynamically allocated nodes which may be freed.
Quoted 7 lines
Signed-off-by Rob Herring (Arm) <[email protected]>--- drivers/cpufreq/cpufreq-dt.c | 11 +++-------- drivers/cpufreq/pmac64-cpufreq.c | 2 +- drivers/cpufreq/sti-cpufreq.c | 2 +-drivers/cpufreq/sun50i-cpufreq-nvmem.c | 2 +-
Quoted 6 lines · Rob Herring (Arm)
Use
of_property_present()to test for property presence rather than of_(find|get)_property(). This is part of a larger effort to remove callers ofof_find_property()and similar functions.of_find_property()leaks the DT struct property and data pointers which is a problem for dynamically allocated nodes which may be freed.
Quoted 7 lines
Signed-off-by Rob Herring (Arm) <[email protected]>--- drivers/cpufreq/cpufreq-dt.c | 11 +++-------- drivers/cpufreq/pmac64-cpufreq.c | 2 +- drivers/cpufreq/sti-cpufreq.c | 2 +- drivers/cpufreq/sun50i-cpufreq-nvmem.c | 2 +- 4 files changed, 6 insertions(+), 11 deletions(-)
Applied. Thanks.
Signature · 1 line
viresh