regulator: Use of_property_read_bool()
PATCH 1/1 regulator: Use of_property_read_bool()
Use of_property_read_bool() to read boolean properties rather than of_get_property(). This is part of a larger effort to remove callers of of_get_property() and similar functions. of_get_property() leaks the DT property data pointer which is a problem for dynamically allocated nodes which may be freed.
--- drivers/regulator/act8865-regulator.c | 4 +--- drivers/regulator/max8997-regulator.c | 5 ++--- 2 files changed, 3 insertions(+), 6 deletions(-)
drivers/regulator/act8865-regulator.c +1 -3
@@ -673,9 +673,7 @@ static int act8865_pmic_probe(struct i2c_client *client) type = (unsigned long ) id->data; - voltage_select = !!of_get_property (dev->of_node, -"active-semi,vsel-high" , -NULL ); + voltage_select =of_property_read_bool (dev->of_node,"active-semi,vsel-high" ); }else { type = i2c_id->driver_data; pdata =dev_get_platdata (dev);
drivers/regulator/max8997-regulator.c +2 -3
@@ -941,9 +941,8 @@ static int max8997_pmic_dt_parse_pdata(struct platform_device *pdev, } } -if (of_get_property (pmic_np, -"max8997,pmic-ignore-gpiodvs-side-effect" ,NULL )) - pdata->ignore_gpiodvs_side_effect = true; + pdata->ignore_gpiodvs_side_effect =of_property_read_bool (pmic_np, +"max8997,pmic-ignore-gpiodvs-side-effect" ); dvs_voltage_nr =8 ; }
Signature · 1 line
2.43.0
Mark Brown
maintainerQuoted 8 lines · Rob Herring (Arm)
Use
of_property_read_bool()to read boolean properties rather thanof_get_property(). This is part of a larger effort to remove callers ofof_get_property()and similar functions.of_get_property()leaks the DT property data pointer which is a problem for dynamically allocated nodes which may be freed.[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
Thanks!
[1/1] regulator: Use of_property_read_bool()
commit: b03695d95213121719f05cbf6f3baa1ad3667e7f
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark