iio: adc: aspeed: Use of_property_present()
Subsystems (2)
PATCH 1/1 iio: adc: aspeed: Use of_property_present()
Use of_property_present() to test for property presence rather than of_find_property(). This is part of a larger effort to remove callers of of_find_property() and similar functions. of_find_property() leaks the DT struct property and data pointers which is a problem for dynamically allocated nodes which may be freed.
--- drivers/iio/adc/aspeed_adc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/iio/adc/aspeed_adc.c +1 -2
@@ -555,8 +555,7 @@ static int aspeed_adc_probe(struct platform_device *pdev)if (ret)return ret; -if (of_find_property (data->dev->of_node,"aspeed,battery-sensing" , -NULL )) { +if (of_property_present (data->dev->of_node,"aspeed,battery-sensing" )) {if (data->model_data->bat_sense_sup) { data->battery_sensing =1 ; if (readl(data->base + ASPEED_REG_ENGINE_CONTROL) &
Signature · 1 line
2.43.0
Quoted 7 lines · Rob Herring (Arm)
Use
of_property_present()to test for property presence rather thanof_find_property(). This is part of a larger effort to remove callers ofof_find_property()and similar functions.of_find_property()leaks the DT struct property and data pointers which is a problem for dynamically allocated nodes which may be freed.Signed-off-by Rob Herring (Arm) <[email protected]>
Quoted 11 lines · On Thu, 01 Aug 2024 11:13:50 +0930 Andrew Jeffery…
Quoted 7 lines · Rob Herring (Arm)
Use
of_property_present()to test for property presence rather thanof_find_property(). This is part of a larger effort to remove callers ofof_find_property()and similar functions.of_find_property()leaks the DT struct property and data pointers which is a problem for dynamically allocated nodes which may be freed.Signed-off-by Rob Herring (Arm) <[email protected]>Acked-by Andrew Jeffery <[email protected]>
Applied.