ufs: Use of_property_present()
PATCH 1/1 ufs: Use of_property_present()
Use of_property_present() to test for property presence rather than of_find_property(). This is part of a larger effort to remove callers of of_find_property() and similar functions. of_find_property() leaks the DT struct property and data pointers which is a problem for dynamically allocated nodes which may be freed.
--- drivers/ufs/host/ufshcd-pltfrm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/ufs/host/ufshcd-pltfrm.c +2 -2
@@ -272,10 +272,10 @@ static int ufshcd_parse_operating_points(struct ufs_hba *hba)const char **clk_names;int cnt, i, ret; -if (!of_find_property (np,"operating-points-v2" ,NULL )) +if (!of_property_present (np,"operating-points-v2" ))return 0 ; -if (of_find_property (np,"freq-table-hz" ,NULL )) { +if (of_property_present (np,"freq-table-hz" )) {dev_err (dev,"%s: operating-points and freq-table-hz are incompatible\n" , __func__);return -EINVAL ;
Signature · 1 line
2.43.0
Quoted 5 lines · Rob Herring (Arm)
Use
of_property_present()to test for property presence rather thanof_find_property(). This is part of a larger effort to remove callers ofof_find_property()and similar functions.of_find_property()leaks the DT struct property and data pointers which is a problem for dynamically allocated nodes which may be freed.
Please add a qualifier past the prefix "ufs:" in the patch subject to make it clear that this patch only modifies the UFS platform driver. Otherwise this patch looks good to me.
Thanks,
Bart.