powerpc: Use of_property_present()
Subsystems (2)
PATCH 1/1 powerpc: Use of_property_present()
Use of_property_present() to test for property presence rather than of_get_property(). This is part of a larger effort to remove callers of of_get_property() and similar functions. of_get_property() leaks the DT property data pointer which is a problem for dynamically allocated nodes which may be freed.
Signed-off-by Rob Herring (Arm) <[email protected]>
--- arch/powerpc/platforms/powernv/eeh-powernv.c | 2 +- arch/powerpc/platforms/powernv/opal-lpc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
arch/powerpc/platforms/powernv/eeh-powernv.c +1 -1
@@ -860,7 +860,7 @@ static int pnv_eeh_bridge_reset(struct pci_dev *pdev, int option)int64_t rc;/* Hot reset to the bus if firmware cannot handle */ -if (!dn || !of_get_property (dn,"ibm,reset-by-firmware" ,NULL )) +if (!dn || !of_property_present (dn,"ibm,reset-by-firmware" ))return __pnv_eeh_bridge_reset (pdev, option); pr_debug("%s: FW reset PCI bus %04x:%02x with option %d\n",
arch/powerpc/platforms/powernv/opal-lpc.c +1 -1
@@ -393,7 +393,7 @@ void __init opal_lpc_init(void)for_each_compatible_node (np,NULL ,"ibm,power8-lpc" ) {if (!of_device_is_available (np))continue ; -if (!of_get_property (np,"primary" ,NULL )) +if (!of_property_present (np,"primary" ))continue ; opal_lpc_chip_id =of_get_ibm_chip_id (np);of_node_put (np);
Signature · 1 line
2.43.0
Michael Ellerman
AppliedQuoted 8 lines · Rob Herring (Arm)
Use
of_property_present()to test for property presence rather thanof_get_property(). This is part of a larger effort to remove callers ofof_get_property()and similar functions.of_get_property()leaks the DT property data pointer which is a problem for dynamically allocated nodes which may be freed.[...]
Applied to powerpc/next.
[1/1] powerpc: Use of_property_present()
https://git.kernel.org/powerpc/c/8a93960abed960b9f6097b6471b7fb34120ffc6a
cheers