net: Use of_property_read_bool()
Subsystems (6)
PATCH 1/1 net: Use of_property_read_bool()
Use of_property_read_bool() to read boolean properties rather than of_find_property(). This is part of a larger effort to remove callers of of_find_property() and similar functions. of_find_property() leaks the DT struct property and data pointers which is a problem for dynamically allocated nodes which may be freed.
--- drivers/net/ethernet/freescale/fman/fman_port.c | 6 +++--- drivers/net/ethernet/ti/icssg/icssg_prueth.c | 8 ++++---- drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c | 8 ++++---- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +- 4 files changed, 12 insertions(+), 12 deletions(-)
drivers/net/ethernet/freescale/fman/fman_port.c +3 -3
@@ -1748,7 +1748,7 @@ static int fman_port_probe(struct platform_device *of_dev)struct resource res;struct resource *dev_res;u32 val; -int err =0 , lenp; +int err =0 ;enum fman_port_type port_type;u16 port_speed;u8 port_id;
@@ -1795,7 +1795,7 @@ static int fman_port_probe(struct platform_device *of_dev)if (of_device_is_compatible (port_node,"fsl,fman-v3-port-tx" )) { port_type =FMAN_PORT_TYPE_TX ; port_speed =1000 ; -if (of_find_property (port_node,"fsl,fman-10g-port" , &lenp)) +if (of_property_read_bool (port_node,"fsl,fman-10g-port" )) port_speed =10000 ; }else if (of_device_is_compatible (port_node,"fsl,fman-v2-port-tx" )) {
@@ -1808,7 +1808,7 @@ static int fman_port_probe(struct platform_device *of_dev) }else if (of_device_is_compatible (port_node,"fsl,fman-v3-port-rx" )) { port_type =FMAN_PORT_TYPE_RX ; port_speed =1000 ; -if (of_find_property (port_node,"fsl,fman-10g-port" , &lenp)) +if (of_property_read_bool (port_node,"fsl,fman-10g-port" )) port_speed =10000 ; }else if (of_device_is_compatible (port_node,"fsl,fman-v2-port-rx" )) {
drivers/net/ethernet/ti/icssg/icssg_prueth.c +4 -4
@@ -1271,8 +1271,8 @@ static int prueth_probe(struct platform_device *pdev) goto exit_iep; } -if (of_find_property (eth0_node,"ti,half-duplex-capable" ,NULL )) - prueth->emac[PRUETH_MAC0 ]->half_duplex =1 ; + prueth->emac[PRUETH_MAC0 ]->half_duplex = +of_property_read_bool (eth0_node,"ti,half-duplex-capable" ); prueth->emac[PRUETH_MAC0 ]->iep = prueth->iep0; }
@@ -1285,8 +1285,8 @@ static int prueth_probe(struct platform_device *pdev) goto netdev_exit; } -if (of_find_property (eth1_node,"ti,half-duplex-capable" ,NULL )) - prueth->emac[PRUETH_MAC1 ]->half_duplex =1 ; + prueth->emac[PRUETH_MAC1 ]->half_duplex = +of_property_read_bool (eth1_node,"ti,half-duplex-capable" ); prueth->emac[PRUETH_MAC1 ]->iep = prueth->iep0; }
drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c +4 -4
@@ -1045,8 +1045,8 @@ static int prueth_probe(struct platform_device *pdev) goto exit_iep; } -if (of_find_property (eth0_node,"ti,half-duplex-capable" ,NULL )) - prueth->emac[PRUETH_MAC0 ]->half_duplex =1 ; + prueth->emac[PRUETH_MAC0 ]->half_duplex = +of_property_read_bool (eth0_node,"ti,half-duplex-capable" ); prueth->emac[PRUETH_MAC0 ]->iep = prueth->iep0; }
@@ -1059,8 +1059,8 @@ static int prueth_probe(struct platform_device *pdev) goto netdev_exit; } -if (of_find_property (eth1_node,"ti,half-duplex-capable" ,NULL )) - prueth->emac[PRUETH_MAC1 ]->half_duplex =1 ; + prueth->emac[PRUETH_MAC1 ]->half_duplex = +of_property_read_bool (eth1_node,"ti,half-duplex-capable" ); prueth->emac[PRUETH_MAC1 ]->iep = prueth->iep1; }
drivers/net/ethernet/xilinx/xilinx_axienet_main.c +1 -1
@@ -2396,7 +2396,7 @@ static int axienet_probe(struct platform_device *pdev) goto cleanup_clk; } -if (!of_find_property (pdev->dev.of_node,"dmas" ,NULL )) { +if (!of_property_present (pdev->dev.of_node,"dmas" )) {/* Find the DMA node, map the DMA registers, and decode the DMA IRQs */ np =of_parse_phandle (pdev->dev.of_node,"axistream-connected" ,0 );
Signature · 1 line
2.43.0
Quoted 7 lines · Rob Herring (Arm)
Use
of_property_read_bool()to read boolean properties rather thanof_find_property(). This is part of a larger effort to remove callers ofof_find_property()and similar functions.of_find_property()leaks the DT struct property and data pointers which is a problem for dynamically allocated nodes which may be freed.Signed-off-by Rob Herring (Arm) <[email protected]>
Signature · 2 lines
Thanks and Regards, Md Danish Anwar
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 9 lines · On Wed, 31 Jul 2024 13:16:00 -0600 you wrote:
Use
of_property_read_bool()to read boolean properties rather thanof_find_property(). This is part of a larger effort to remove callers ofof_find_property()and similar functions.of_find_property()leaks the DT struct property and data pointers which is a problem for dynamically allocated nodes which may be freed.Signed-off-by Rob Herring (Arm) <[email protected]>[...]
Here is the summary with links:
- [net-next] net: Use of_property_read_bool()
https://git.kernel.org/netdev/net-next/c/5fe164fb0e6e
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html