pwm: lp3943: Use of_property_count_u32_elems() to get property length
PATCH 1/1 pwm: lp3943: Use of_property_count_u32_elems() to get property length
Replace of_get_property() with the type specific of_property_count_u32_elems() to get the property length.
This is part of a larger effort to remove callers of of_get_property() and similar functions. of_get_property() leaks the DT property data pointer which is a problem for dynamically allocated nodes which may be freed.
--- drivers/pwm/pwm-lp3943.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
drivers/pwm/pwm-lp3943.c +3 -6
@@ -218,7 +218,7 @@ static int lp3943_pwm_parse_dt(struct device *dev,struct lp3943_platform_data *pdata;struct lp3943_pwm_map *pwm_map;enum lp3943_pwm_output *output; -int i, err, proplen, count =0 ; +int i, err, count =0 ;u32 num_outputs;if (!node)
@@ -234,11 +234,8 @@ static int lp3943_pwm_parse_dt(struct device *dev,*/ for (i =0 ; i <LP3943_NUM_PWMS ; i++) { -if (!of_get_property (node, name[i], &proplen)) -continue ; - - num_outputs = proplen /sizeof (u32); -if (num_outputs ==0 ) + num_outputs =of_property_count_u32_elems (node, name[i]); +if (num_outputs <=0 )continue ; output = devm_kcalloc(dev, num_outputs, sizeof(*output),
Signature · 1 line
2.43.0
Hello Rob,
Quoted 7 lines · Rob Herring (Arm)
Replace
of_get_property()with the type specificof_property_count_u32_elems()to get the property length.This is part of a larger effort to remove callers of
of_get_property()and similar functions.of_get_property()leaks the DT property data pointer which is a problem for dynamically allocated nodes which may be freed.
To understand that right: The problem is that of_get_property() returns pp->value, which might be freed. In this driver this isn't problematic as the returned value is just used for a NULL check. So this isn't urgent and queuing it for the next merge window is fine, right?
Best regards
Uwe
Quoted 12 lines · Uwe Kleine-König
Hello Rob,
Quoted 7 lines · Rob Herring (Arm)
Replace
of_get_property()with the type specificof_property_count_u32_elems()to get the property length.This is part of a larger effort to remove callers of
of_get_property()and similar functions.of_get_property()leaks the DT property data pointer which is a problem for dynamically allocated nodes which may be freed.
Quoted 4 lines
To understand that right: The problem is that
of_get_property()returnspp->value, which might be freed. In this driver this isn't problematic as the returned value is just used for a NULL check. So this isn't urgent and queuing it for the next merge window is fine, right?
Yes, 6.12 is fine.
Rob
Hello Rob,
Quoted 11 lines · Rob Herring
Quoted 9 lines · Uwe Kleine-König
Quoted 7 lines · Rob Herring (Arm)
Replace
of_get_property()with the type specificof_property_count_u32_elems()to get the property length.This is part of a larger effort to remove callers of
of_get_property()and similar functions.of_get_property()leaks the DT property data pointer which is a problem for dynamically allocated nodes which may be freed.
Quoted 6 lines
Quoted 4 lines
To understand that right: The problem is that
of_get_property()returnspp->value, which might be freed. In this driver this isn't problematic as the returned value is just used for a NULL check. So this isn't urgent and queuing it for the next merge window is fine, right?Yes, 6.12 is fine.
Thanks for confirming, queued in
https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next for 6.12-rc.
Best regards
Uwe