Skip to contentSkip to conversation

f2fs: atomic: fix to truncate pagecache before on-disk metadata truncation

PATCH Superseded Chao Yu 2 participants 2 messages Aug 1, 2024 – Aug 6, 2024 F2FS file system

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Chao Yu

author maintainer
#0 lore raw

PATCH v3 3/4 f2fs: atomic: fix to truncate pagecache before on-disk metadata truncation

We should always truncate pagecache while truncating on-disk data.

Fixes a46bebd502fe ("f2fs: synchronize atomic write aborts")

---
v3:
- check dirty page before truncation
- use invalidate_mapping_pages() instead of truncate_inode_pages()
- set i_size to zero after truncation

 fs/f2fs/file.c | 6 ++++++
 1 file changed, 6 insertions(+)
fs/f2fs/file.c +6 -0
index ac61c88f7688..a316c21539d1 100644
@@ -2199,11 +2199,17 @@ static int f2fs_ioc_start_atomic_write(struct file *filp, bool truncate)
 		F2FS_I(fi->cow_inode)->atomic_inode = inode;
 	} else {
 		/* Reuse the already created COW inode */
+		f2fs_bug_on(sbi, get_dirty_pages(fi->cow_inode));
+
+		invalidate_mapping_pages(fi->cow_inode->i_mapping, 0, -1);
+
 		ret = f2fs_do_truncate_blocks(fi->cow_inode, 0, true);
 		if (ret) {
 			f2fs_up_write(&fi->i_gc_rwsem[WRITE]);
 			goto out;
 		}
+
+		i_size_write(fi->cow_inode, 0);
 	}
 
 	f2fs_write_inode(inode, NULL);
Signature · 1 line
2.40.1
maintainer
#1 lore raw
Quoted 21 lines · Chao Yu

We should always truncate pagecache while truncating on-disk data.

Fixes a46bebd502fe ("f2fs: synchronize atomic write aborts")

---
v3:
- check dirty page before truncation
- use invalidate_mapping_pages() instead of truncate_inode_pages()
- set i_size to zero after truncation

 fs/f2fs/file.c | 6 ++++++
 1 file changed, 6 insertions(+)
fs/f2fs/file.c +1 -0
index ac61c88f7688..a316c21539d1 100644
@@ -2199,11 +2199,17 @@ static int f2fs_ioc_start_atomic_write(struct file *filp, bool truncate)
 		F2FS_I(fi->cow_inode)->atomic_inode = inode;
 	} else {
 		/* Reuse the already created COW inode */
+		f2fs_bug_on(sbi, get_dirty_pages(fi->cow_inode));

fs/f2fs/file.c static int f2fs_ioc_start_atomic_write(struct file *filp, bool truncate) · line 2212

Quoted 10 lines
fs/f2fs/file.c +5 -0
+
+		invalidate_mapping_pages(fi->cow_inode->i_mapping, 0, -1);
+
 		ret = f2fs_do_truncate_blocks(fi->cow_inode, 0, true);
 		if (ret) {
 			f2fs_up_write(&fi->i_gc_rwsem[WRITE]);
 			goto out;
 		}
+
+		i_size_write(fi->cow_inode, 0);

Do we really need this?

Quoted 5 lines
fs/f2fs/file.c +0 -0
 	}
 
 	f2fs_write_inode(inode, NULL);
Signature · 1 line
2.40.1