Skip to contentSkip to conversation

Drivers: hv: vmbus: Fix the misplaced function description

PATCH Applied Roman Kisel 3 participants 3 messages Aug 1, 2024 – Aug 3, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Drivers: hv: vmbus: Fix the misplaced function description

When hv_synic_disable_regs was introduced, it received the description of hv_synic_cleanup. Fix that.

Fixes dba61cda3046 ("Drivers: hv: vmbus: Break out synic enable and disable operations")
---
 drivers/hv/hv.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/hv/hv.c +3 -3
index e0d676c74f14..36d9ba097ff5 100644
@@ -342,9 +342,6 @@ int hv_synic_init(unsigned int cpu)
 	return 0;
 }
 
-/*
- * hv_synic_cleanup - Cleanup routine for hv_synic_init().
- */
 void hv_synic_disable_regs(unsigned int cpu)
 {
 	struct hv_per_cpu_context *hv_cpu =
@@ -436,6 +433,9 @@ static bool hv_synic_event_pending(void)
 	return pending;
 }
 
+/*
+ * hv_synic_cleanup - Cleanup routine for hv_synic_init().
+ */
 int hv_synic_cleanup(unsigned int cpu)
 {
 	struct vmbus_channel *channel, *sc;

base-commit: 831bcbcead6668ebf20b64fdb27518f1362ace3a

Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw

From: Roman Kisel <[email protected]> Sent: Thursday, August 1, 2024 2:23 PM

Quoted 37 lines

When hv_synic_disable_regs was introduced, it received the description of hv_synic_cleanup. Fix that.

Fixes dba61cda3046 ("Drivers: hv: vmbus: Break out synic enable and disable

operations")

---
 drivers/hv/hv.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/hv/hv.c +3 -3
index e0d676c74f14..36d9ba097ff5 100644
@@ -342,9 +342,6 @@ int hv_synic_init(unsigned int cpu)
 	return 0;
 }
 
-/*
- * hv_synic_cleanup - Cleanup routine for hv_synic_init().
- */
 void hv_synic_disable_regs(unsigned int cpu)
 {
 	struct hv_per_cpu_context *hv_cpu =
@@ -436,6 +433,9 @@ static bool hv_synic_event_pending(void)
 	return pending;
 }
 
+/*
+ * hv_synic_cleanup - Cleanup routine for hv_synic_init().
+ */
 int hv_synic_cleanup(unsigned int cpu)
 {
 	struct vmbus_channel *channel, *sc;
Quoted 4 lines

base-commit: 831bcbcead6668ebf20b64fdb27518f1362ace3a --
2.34.1

maintainer Applied
#2 lore raw
Quoted 38 lines · Michael Kelley

From: Roman Kisel <[email protected]> Sent: Thursday, August 1, 2024 2:23 PM

Quoted 37 lines

When hv_synic_disable_regs was introduced, it received the description of hv_synic_cleanup. Fix that.

Fixes dba61cda3046 ("Drivers: hv: vmbus: Break out synic enable and disable

operations")

---
 drivers/hv/hv.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/hv/hv.c +3 -3
index e0d676c74f14..36d9ba097ff5 100644
@@ -342,9 +342,6 @@ int hv_synic_init(unsigned int cpu)
 	return 0;
 }
 
-/*
- * hv_synic_cleanup - Cleanup routine for hv_synic_init().
- */
 void hv_synic_disable_regs(unsigned int cpu)
 {
 	struct hv_per_cpu_context *hv_cpu =
@@ -436,6 +433,9 @@ static bool hv_synic_event_pending(void)
 	return pending;
 }
 
+/*
+ * hv_synic_cleanup - Cleanup routine for hv_synic_init().
+ */
 int hv_synic_cleanup(unsigned int cpu)
 {
 	struct vmbus_channel *channel, *sc;
Quoted 7 lines
Quoted 4 lines

base-commit: 831bcbcead6668ebf20b64fdb27518f1362ace3a --
2.34.1

Applied to hyperv-fixes. Thanks.