Skip to contentSkip to conversation

arm64: dts: rockchip: make USB gadget functions usable on Radxa ROCK 3C

PATCH In review FUKAUMI Naoki 1 participant 2 messages Aug 2, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: rockchip: make USB gadget functions usable on Radxa ROCK 3C

Radxa ROCK 3A and 3B use a USB 3.0 Type-A OTG port as "otg" mode for USB gadget functions.

Radxa ROCK 3C also has a USB 2.0 Type-A OTG port, it should be "otg" mode for USB gadget functions.

Fixes ee219017ddb5 ("arm64: dts: rockchip: Add Radxa ROCK 3C")
---
 arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts +0 -1
index f2cc086e5001..a9535eaa5235 100644
@@ -664,7 +664,6 @@ &usb_host0_ohci {
 };
 
 &usb_host0_xhci {
-	dr_mode = "host";
 	status = "okay";
 };
 
Signature · 7 lines
2.43.0


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
#1 lore raw

hi,

please don't merge this for a while.

I'm thinking opposite change may be better to align with ROCK 4/5 series. (OTG port is "host")

any comment?

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

Quoted 17 lines · FUKAUMI Naoki

Radxa ROCK 3A and 3B use a USB 3.0 Type-A OTG port as "otg" mode for USB gadget functions.

Radxa ROCK 3C also has a USB 2.0 Type-A OTG port, it should be "otg" mode for USB gadget functions.

Fixes ee219017ddb5 ("arm64: dts: rockchip: Add Radxa ROCK 3C")
---
  arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts | 1 -
  1 file changed, 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts +0 -0
index f2cc086e5001..a9535eaa5235 100644

arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts &usb_host0_ohci { · line 669

Quoted 7 lines
arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts +0 -1
@@ -664,7 +664,6 @@ &usb_host0_ohci {
  };
 
  &usb_host0_xhci {
-	dr_mode = "host";
  	status = "okay";
  };
 

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip