file: remove outdated comment after close_fd()
PATCH 1/1 file: remove outdated comment after close_fd()
The comment on EXPORT_SYMBOL(close_fd) was added in commit 2ca2a09d6215 ("fs: add ksys_close() wrapper; remove in-kernel calls to sys_close()"), before commit 8760c909f54a ("file: Rename __close_fd to close_fd and remove the files parameter") gave the function its current name, however commit 1572bfdf21d4 ("file: Replace ksys_close with close_fd") removes the referenced caller entirely, obsoleting this comment.
--- fs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/file.c +1 -1
@@ -676,7 +676,7 @@ int close_fd(unsigned fd)return filp_close (file, files); } -EXPORT_SYMBOL (close_fd);/* for ksys_close() */ +EXPORT_SYMBOL (close_fd);/** * last_fd - return last valid index into fd table
Signature · 1 line
2.45.2
Quoted 5 lines · Joel Savitz
Cc Alexander Viro <[email protected]>Cc Christian Brauner <[email protected]>Cc Jan Kara <[email protected]>
Quoted 8 lines
The comment on
EXPORT_SYMBOL(close_fd)was added in commit2ca2a09d6215("fs: addksys_close()wrapper; remove in-kernel calls tosys_close()"), before commit8760c909f54a("file: Rename__close_fdtoclose_fdand remove the files parameter") gave the function its current name, however commit1572bfdf21d4("file: Replaceksys_closewithclose_fd") removes the referenced caller entirely, obsoleting this comment.Signed-off-by Joel Savitz <[email protected]>
Looks good. Feel free to add:
Honza
Quoted 20 lines
--- fs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/file.c +1
-1@@ -676,7 +676,7 @@ int close_fd(unsigned fd)return filp_close (file, files); } -EXPORT_SYMBOL (close_fd);/* for ksys_close() */ +EXPORT_SYMBOL (close_fd);/** * last_fd - return last valid index into fd table Signature · 1 line
2.45.2
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR