ACPI: button: Use strscpy instead of strcpy.
PATCH 1/1 ACPI: button: Use strscpy instead of strcpy.
In reply to a message not in the archiveReplace strcpy() with strscpy() in the ACPI button driver.
strcpy() has been deprecated because it is generally unsafe, so help to eliminate it from the kernel source.
Signed-off-by Muhammad Qasim Abdul Majeed <[email protected]>
<This is more than advertised in the changelog>
The patch has been updated.
--- drivers/acpi/button.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/acpi/button.c +3 -3
@@ -547,20 +547,20 @@ static int acpi_button_add(struct acpi_device *device) !strcmp(hid, ACPI_BUTTON_HID_POWERF)) { button->type =ACPI_BUTTON_TYPE_POWER ; handler = acpi_button_notify; -strcpy (name,ACPI_BUTTON_DEVICE_NAME_POWER ); +strscpy (name,ACPI_BUTTON_DEVICE_NAME_POWER ,MAX_ACPI_DEVICE_NAME_LEN );sprintf (class,"%s/%s" ,ACPI_BUTTON_CLASS ,ACPI_BUTTON_SUBCLASS_POWER ); } else if (!strcmp(hid, ACPI_BUTTON_HID_SLEEP) || !strcmp(hid, ACPI_BUTTON_HID_SLEEPF)) { button->type =ACPI_BUTTON_TYPE_SLEEP ; handler = acpi_button_notify; -strcpy (name,ACPI_BUTTON_DEVICE_NAME_SLEEP ); +strscpy (name,ACPI_BUTTON_DEVICE_NAME_SLEEP ,MAX_ACPI_DEVICE_NAME_LEN );sprintf (class,"%s/%s" ,ACPI_BUTTON_CLASS ,ACPI_BUTTON_SUBCLASS_SLEEP ); } else if (!strcmp(hid, ACPI_BUTTON_HID_LID)) { button->type =ACPI_BUTTON_TYPE_LID ; handler = acpi_lid_notify; -strcpy (name,ACPI_BUTTON_DEVICE_NAME_LID ); +strscpy (name,ACPI_BUTTON_DEVICE_NAME_LID ,MAX_ACPI_DEVICE_NAME_LEN );sprintf (class,"%s/%s" ,ACPI_BUTTON_CLASS ,ACPI_BUTTON_SUBCLASS_LID ); input->open = acpi_lid_input_open;
Signature · 1 line
2.34.1