Skip to contentSkip to conversation

package/xz: avoid cicular dependency on autoconf for host builds

PATCH Applied Markus Mayer via buildroot 1 participant 2 messages Aug 6, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/xz: avoid cicular dependency on autoconf for host builds

autoconf has an implicit dependency on HOST_XZ due to extracting a tar.xz archive. By enabling XZ_AUTORECONF we create a reverse dependency for xz on autoconf. This is fine for target builds, but it won't work for host builds, as the two packages now depend on each other.

This problem only occurs if host tools are being built by Buildroot. If the build relies on host tools provided by the distro, there is no circular dependency problem.

Fixes:
4703a7ae9176 package/xz: fix musl static build

---
 package/xz/xz.mk | 7 +++++++
 1 file changed, 7 insertions(+)
package/xz/xz.mk +7 -0
index 9fb93ff4d6b5..028cd5bdf525 100644
@@ -68,5 +68,12 @@ HOST_XZ_CONF_ENV = \
 	CC="$(HOSTCC_NOCCACHE)" \
 	CXX="$(HOSTCXX_NOCCACHE)"
 
+# We need to prevent XZ_AUTORECONF for host builds or we end up with a circular
+# dependency. Since the autoconf build needs to extract a tar.xz archive,
+# autoconf has an implicit dependency on HOST_XZ. By enabling XZ_AUTORECONF we
+# also make host-xz depend on autoconf, which we can't do. It is also not
+# necessary.
+HOST_XZ_AUTORECONF = NO
+
 $(eval $(autotools-package))
 $(eval $(host-autotools-package))
Signature · 6 lines
2.46.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 9 lines · On Mon, 5 Aug 2024 20:06:59 -0700 Markus Mayer via buildroot…

autoconf has an implicit dependency on HOST_XZ due to extracting a tar.xz archive. By enabling XZ_AUTORECONF we create a reverse dependency for xz on autoconf. This is fine for target builds, but it won't work for host builds, as the two packages now depend on each other.

This problem only occurs if host tools are being built by Buildroot. If the build relies on host tools provided by the distro, there is no circular dependency problem.

Quoted 7 lines

Fixes:
4703a7ae9176 package/xz: fix musl static build

---
 package/xz/xz.mk | 7 +++++++
 1 file changed, 7 insertions(+)

Applied to master, thanks.

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot