Skip to contentSkip to conversation

kbuild: rust-analyzer: mark `rust_is_available.sh` invocation as recursive

PATCH Applied Miguel Ojeda 3 participants 4 messages Aug 6, 2024 – Aug 9, 2024

Subsystems (2)
lore
Share & tools
lore

Miguel Ojeda

author maintainer
#0 lore raw

PATCH 1/1 kbuild: rust-analyzer: mark `rust_is_available.sh` invocation as recursive

When calling the rust_is_available.sh script, we need to make the jobserver available to it, as commit ecab4115c44c ("kbuild: mark rustc (and others) invocations as recursive") explains and did for the others.

Otherwise, we get a warning from rustc. Thus fix it.

Fixes 6dc9d9ca9a72 ("kbuild: rust-analyzer: better error handling")
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
index 44c02a6f60a1..9a33b6063a30 100644
@@ -1963,7 +1963,7 @@ tags TAGS cscope gtags: FORCE
 # Protocol).
 PHONY += rust-analyzer
 rust-analyzer:
-	$(Q)$(CONFIG_SHELL) $(srctree)/scripts/rust_is_available.sh
+	+$(Q)$(CONFIG_SHELL) $(srctree)/scripts/rust_is_available.sh
 	$(Q)$(MAKE) $(build)=rust $@
 
 # Script to generate missing namespace dependencies

base-commit: de9c2c66ad8e787abec7c9d7eff4f8c3cdd28aed

Signature · 1 line
2.46.0
#1 lore raw
Quoted 2 lines · Miguel Ojeda

Otherwise, we get a warning from rustc. Thus fix it.

To be clear, this happens (only) when calling make with parallel jobs, e.g. -j8.

Which does not really matter for that target, but nevertheless, some of us call make with jobs enabled most of the time.

Cheers,
Miguel

reviewer Reviewed-by on v1 1/1
#2 lore raw
In reply to Miguel Ojeda
Quoted 9 lines · Miguel Ojeda

When calling the rust_is_available.sh script, we need to make the jobserver available to it, as commit ecab4115c44c ("kbuild: mark rustc (and others) invocations as recursive") explains and did for the others.

Otherwise, we get a warning from rustc. Thus fix it.

Fixes 6dc9d9ca9a72 ("kbuild: rust-analyzer: better error handling")
Applied
#3 lore raw
In reply to Miguel Ojeda
Quoted 9 lines · Miguel Ojeda

When calling the rust_is_available.sh script, we need to make the jobserver available to it, as commit ecab4115c44c ("kbuild: mark rustc (and others) invocations as recursive") explains and did for the others.

Otherwise, we get a warning from rustc. Thus fix it.

Fixes 6dc9d9ca9a72 ("kbuild: rust-analyzer: better error handling")

Applied to rust-fixes -- thanks everyone!

[ Reworded to add a couple more details mentioned in the list. - Miguel ]

Cheers,
Miguel