Skip to contentSkip to conversation

dt-bindings: dma: fsl,imx-dma: Document the DMA clocks

PATCH Applied Fabio Estevam 3 participants 3 messages Aug 7, 2024 – Aug 29, 2024

Subsystems (3)
Device tree bindings Arm i.MX and Layerscape dmaengine
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH v2 1/1 dt-bindings: dma: fsl,imx-dma: Document the DMA clocks

From: Fabio Estevam <[email protected]>

Document the IPG and AHB clocks that are needed by the DMA hardware as required properties.

It is not possible to have DMA functional without the DMA clocks being turned on.

Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- Mark clock and clock-names as required properties (Conor).

 .../devicetree/bindings/dma/fsl,imx-dma.yaml       | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
Documentation/devicetree/bindings/dma/fsl,imx-dma.yaml +14 -0
index 902a11f65be2..75957f9fb58b 100644
@@ -28,6 +28,14 @@ properties:
       - description: DMA Error interrupt
     minItems: 1
 
+  clocks:
+    maxItems: 2
+
+  clock-names:
+    items:
+      - const: ipg
+      - const: ahb
+
   "#dma-cells":
     const: 1
 

@@ -42,15 +50,21 @@ required:
   - reg
   - interrupts
   - "#dma-cells"
+  - clocks
+  - clock-names
 
 additionalProperties: false
 
 examples:
   - |
+    #include <dt-bindings/clock/imx27-clock.h>
+
     dma-controller@10001000 {
       compatible = "fsl,imx27-dma";
       reg = <0x10001000 0x1000>;
       interrupts = <32 33>;
       #dma-cells = <1>;
       dma-channels = <16>;
+      clocks = <&clks IMX27_CLK_DMA_IPG_GATE>, <&clks IMX27_CLK_DMA_AHB_GATE>;
+      clock-names = "ipg", "ahb";
     };
Signature · 1 line
2.34.1
maintainer Applied
#2 lore raw
In reply to Fabio Estevam
Quoted 8 lines · Fabio Estevam

Document the IPG and AHB clocks that are needed by the DMA hardware as required properties.

It is not possible to have DMA functional without the DMA clocks being turned on.

[...]

Applied, thanks!

[1/1] dt-bindings: dma: fsl,imx-dma: Document the DMA clocks

      commit: 2ccf4822683336f027a5c9f12cb2468e329125d9

Best regards,

Signature · 1 line
~Vinod