Skip to contentSkip to conversation

treewide: remove unnecessary <linux/version.h> inclusion

PATCH In review Masahiro Yamada 2 participants 2 messages Aug 7, 2024

Subsystems (9)
Media (V4L/DVB) Sound Staging Kbuild +5 more subsystems
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 treewide: remove unnecessary <linux/version.h> inclusion

These files do not use any macros defined in <linux/version.h>.

---

 drivers/accessibility/speakup/genmap.c                | 1 -
 drivers/accessibility/speakup/makemapdata.c           | 1 -
 drivers/staging/media/atomisp/include/linux/atomisp.h | 1 -
 samples/trace_events/trace_custom_sched.c             | 1 -
 sound/soc/codecs/cs42l42.c                            | 1 -
 5 files changed, 5 deletions(-)
drivers/accessibility/speakup/genmap.c +0 -1
index 0125000e00d9..0882bab10fb8 100644
@@ -10,7 +10,6 @@
 #include <stdio.h>
 #include <libgen.h>
 #include <string.h>
-#include <linux/version.h>
 #include <ctype.h>
 #include "utils.h"
 
drivers/accessibility/speakup/makemapdata.c +0 -1
index d7d41bb9b05f..55e4ef8a93dc 100644
@@ -10,7 +10,6 @@
 #include <stdio.h>
 #include <libgen.h>
 #include <string.h>
-#include <linux/version.h>
 #include <ctype.h>
 #include "utils.h"
 
drivers/staging/media/atomisp/include/linux/atomisp.h +0 -1
index 16c9da172c03..fefbe3cd08f3 100644
@@ -20,7 +20,6 @@
 #define _ATOM_ISP_H
 
 #include <linux/types.h>
-#include <linux/version.h>
 
 /* struct media_device_info.hw_revision */
 #define ATOMISP_HW_REVISION_MASK	0x0000ff00
samples/trace_events/trace_custom_sched.c +0 -1
index b99d9ab7db85..dd409b704b35 100644
@@ -8,7 +8,6 @@
 #define pr_fmt(fmt) fmt
 
 #include <linux/trace_events.h>
-#include <linux/version.h>
 #include <linux/module.h>
 #include <linux/sched.h>
 
sound/soc/codecs/cs42l42.c +0 -1
index 60d366e53526..6400ac875e6f 100644
@@ -11,7 +11,6 @@
 
 #include <linux/module.h>
 #include <linux/moduleparam.h>
-#include <linux/version.h>
 #include <linux/types.h>
 #include <linux/init.h>
 #include <linux/delay.h>
Signature · 1 line
2.43.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 12 lines · Masahiro Yamada

These files do not use any macros defined in <linux/version.h>.

---

 drivers/accessibility/speakup/genmap.c                | 1 -
 drivers/accessibility/speakup/makemapdata.c           | 1 -
 drivers/staging/media/atomisp/include/linux/atomisp.h | 1 -
 samples/trace_events/trace_custom_sched.c             | 1 -
 sound/soc/codecs/cs42l42.c                            | 1 -
 5 files changed, 5 deletions(-)

Re-checking with

    $ git grep -rle '#include <linux/version.h>' >files-including-version.h
    $ <files-including-version.h xargs git grep -lr -eLINUX_VERSION_{CODE,MAJOR,PATCHLEVEL,SUBLEVEL} -e KERNEL_VERSION >using-macros-from-version.h
    $ diff files-including-version.h using-macros-from-version.h 

reveals that also

tools/testing/selftests/bpf/progs/dev_cgroup.c tools/testing/selftests/bpf/progs/netcnt_prog.c tools/testing/selftests/bpf/progs/test_map_lock.c tools/testing/selftests/bpf/progs/test_send_signal_kern.c tools/testing/selftests/bpf/progs/test_spin_lock.c tools/testing/selftests/bpf/progs/test_tcp_estats.c tools/testing/selftests/wireguard/qemu/init.c

are including but not using linux/version.h. This shall probably not go through kbuild tree, so it looks complete (enough) to me, thanks!