i2c: imx: Switch to RUNTIME_PM_OPS()
Fabio Estevam
reviewerPATCH 1/1 i2c: imx: Switch to RUNTIME_PM_OPS()
From: Fabio Estevam <[email protected]>
Replace SET_RUNTIME_PM_OPS() with its modern RUNTIME_PM_OPS() alternative.
The combined usage of pm_ptr() and RUNTIME_PM_OPS() allows the compiler to evaluate if the runtime suspend/resume() functions are used at build time or are simply dead code.
This allows removing the __maybe_unused notation from the runtime suspend/resume() functions.
--- drivers/i2c/busses/i2c-imx.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
drivers/i2c/busses/i2c-imx.c +4 -5
@@ -1549,7 +1549,7 @@ static void i2c_imx_remove(struct platform_device *pdev)pm_runtime_disable (&pdev->dev); } -static int __maybe_unused i2c_imx_runtime_suspend (struct device *dev) +static int i2c_imx_runtime_suspend (struct device *dev) {struct imx_i2c_struct *i2c_imx =dev_get_drvdata (dev);
@@ -1558,7 +1558,7 @@ static int __maybe_unused i2c_imx_runtime_suspend(struct device *dev)return 0 ; } -static int __maybe_unused i2c_imx_runtime_resume (struct device *dev) +static int i2c_imx_runtime_resume (struct device *dev) {struct imx_i2c_struct *i2c_imx =dev_get_drvdata (dev);int ret;
@@ -1571,8 +1571,7 @@ static int __maybe_unused i2c_imx_runtime_resume(struct device *dev) }static const struct dev_pm_ops i2c_imx_pm_ops = { -SET_RUNTIME_PM_OPS (i2c_imx_runtime_suspend, - i2c_imx_runtime_resume,NULL ) +RUNTIME_PM_OPS (i2c_imx_runtime_suspend, i2c_imx_runtime_resume,NULL ) };static struct platform_driver i2c_imx_driver = {
@@ -1580,7 +1579,7 @@ static struct platform_driver i2c_imx_driver = { .remove_new = i2c_imx_remove, .driver = { .name = DRIVER_NAME, - .pm = &i2c_imx_pm_ops, + .pm = pm_ptr(&i2c_imx_pm_ops), .of_match_table = i2c_imx_dt_ids, .acpi_match_table = i2c_imx_acpi_ids, },
Signature · 1 line
2.34.1
Quoted 5 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Replace
SET_RUNTIME_PM_OPS()with its modernRUNTIME_PM_OPS()alternative.
Quoted 8 lines
The combined usage of
pm_ptr()andRUNTIME_PM_OPS()allows the compiler to evaluate if the runtime suspend/resume() functions are used at build time or are simply dead code.This allows removing the
__maybe_unusednotation from the runtime suspend/resume() functions.Signed-off-by Fabio Estevam <[email protected]>
Thank you!
Regards,
Oleksij
Signature · 4 lines
Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Hi Fabio,
Quoted 5 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Replace
SET_RUNTIME_PM_OPS()with its modernRUNTIME_PM_OPS()alternative.
Quoted 8 lines
The combined usage of
pm_ptr()andRUNTIME_PM_OPS()allows the compiler to evaluate if the runtime suspend/resume() functions are used at build time or are simply dead code.This allows removing the
__maybe_unusednotation from the runtime suspend/resume() functions.Signed-off-by Fabio Estevam <[email protected]>
pushed to i2c/i2c-host.
Thanks,
Andi