Skip to contentSkip to conversation

drm/amd/sriov: extend NV_MAILBOX_POLL_MSG_TIMEDOUT

PATCH In review Victor Zhao 2 participants 2 messages Aug 8, 2024 – Aug 9, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amd/sriov: extend NV_MAILBOX_POLL_MSG_TIMEDOUT

on MI300/MI308 UBB products, when doing mode1 reset, since 1 gpu need to wait all 8 gpus finish mode1 reset and then do re-init. As observed, sometimes the gpu which triggered the reset need to wait 15s for all gpus to finish.

If poll msg timeout, guest driver will send the reset message again, and may mess up the following reinit sequence on other gpus.

So extend the time to cover the maximum time needed to recover.

---
 drivers/gpu/drm/amd/amdgpu/mxgpu_nv.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/mxgpu_nv.h +1 -1
index caf616a2c8a6..1d099ffb3a5a 100644
@@ -25,7 +25,7 @@
 #define __MXGPU_NV_H__
 
 #define NV_MAILBOX_POLL_ACK_TIMEDOUT	500
-#define NV_MAILBOX_POLL_MSG_TIMEDOUT	6000
+#define NV_MAILBOX_POLL_MSG_TIMEDOUT	15000
 #define NV_MAILBOX_POLL_FLR_TIMEDOUT	10000
 #define NV_MAILBOX_POLL_MSG_REP_MAX	11
 
Signature · 1 line
2.34.1
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Victor Zhao

on MI300/MI308 UBB products, when doing mode1 reset, since 1 gpu need to wait all 8 gpus finish mode1 reset and then do re-init. As observed, sometimes the gpu which triggered the reset need to wait 15s for all gpus to finish.

Quoted 6 lines

If poll msg timeout, guest driver will send the reset message again, and may mess up the following reinit sequence on other gpus.

So extend the time to cover the maximum time needed to recover.

Quoted 20 lines
---
 drivers/gpu/drm/amd/amdgpu/mxgpu_nv.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/mxgpu_nv.h +1 -2
index caf616a2c8a6..1d099ffb3a5a 100644
@@ -25,7 +25,7 @@
 #define __MXGPU_NV_H__
 
 #define NV_MAILBOX_POLL_ACK_TIMEDOUT   500
-#define NV_MAILBOX_POLL_MSG_TIMEDOUT   6000
+#define NV_MAILBOX_POLL_MSG_TIMEDOUT   15000
 #define NV_MAILBOX_POLL_FLR_TIMEDOUT   10000
 #define NV_MAILBOX_POLL_MSG_REP_MAX    11
 
--

2.34.1