Skip to contentSkip to conversation

ALSA: usb-audio: Check shutdown at endpoint_set_interface()

PATCH New Takashi Iwai 1 participant 1 message Aug 8, 2024 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: usb-audio: Check shutdown at endpoint_set_interface()

The call of usb_set_interface() and a delay are superfluous when the device has been already disconnected. Add a disconnection check before doing it.

---
 sound/usb/endpoint.c | 3 +++
 1 file changed, 3 insertions(+)
sound/usb/endpoint.c +3 -0
index 8f65349a06d3..568099467dbb 100644
@@ -921,6 +921,9 @@ static int endpoint_set_interface(struct snd_usb_audio *chip,
 
 	if (ep->iface_ref->altset == altset)
 		return 0;
+	/* already disconnected? */
+	if (unlikely(atomic_read(&chip->shutdown)))
+		return -ENODEV;
 
 	usb_audio_dbg(chip, "Setting usb interface %d:%d for EP 0x%x\n",
 		      ep->iface, altset, ep->ep_num);
Signature · 1 line
2.43.0