Skip to contentSkip to conversation

ALSA: timer: Relax start tick time check for slave timer elements

PATCH New Takashi Iwai 1 participant 1 message Aug 10, 2024 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: timer: Relax start tick time check for slave timer elements

The recent addition of a sanity check for a too low start tick time seems breaking some applications that uses aloop with a certain slave timer setup. They may have the initial resolution 0, hence it's treated as if it were a too low value.

Relax and skip the check for the slave timer instance for addressing the regression.

Fixes 4a63bd179fa8 ("ALSA: timer: Set lower bound of start tick time")
---
 sound/core/timer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/core/timer.c +1 -1
index d104adc75a8b..71a07c1662f5 100644
@@ -547,7 +547,7 @@ static int snd_timer_start1(struct snd_timer_instance *timeri,
 	/* check the actual time for the start tick;
 	 * bail out as error if it's way too low (< 100us)
 	 */
-	if (start) {
+	if (start && !(timer->hw.flags & SNDRV_TIMER_HW_SLAVE)) {
 		if ((u64)snd_timer_hw_resolution(timer) * ticks < 100000)
 			return -EINVAL;
 	}
Signature · 1 line
2.43.0