staging: drivers: scsi: lpfc: Fix warning: Using plain integer as NULL pointer in lpfc_init.c
Subsystems (2)
PATCH 1/1 staging: drivers: scsi: lpfc: Fix warning: Using plain integer as NULL pointer in lpfc_init.c
sparse reported following warnings:
'''drivers/scsi/lpfc/lpfc_init.c:5517:32: warning: Using plain integer as NULL pointer drivers/scsi/lpfc/lpfc_init.c:5526:32: warning: Using plain integer as NULL pointer '''
This patch chanes integer 0 to NULL.
--- drivers/scsi/lpfc/lpfc_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/lpfc/lpfc_init.c +2 -2
@@ -5514,7 +5514,7 @@ lpfc_sli4_perform_vport_cvl(struct lpfc_vport *vport)/* Cannot find existing Fabric ndlp, so allocate a new one */ ndlp =lpfc_nlp_init (vport, Fabric_DID);if (!ndlp) -return 0 ; +return NULL ;/* Set the node type */ ndlp->nlp_type |=NLP_FABRIC ;/* Put ndlp onto node list */
@@ -5523,7 +5523,7 @@ lpfc_sli4_perform_vport_cvl(struct lpfc_vport *vport)/* re-setup ndlp without removing from node list */ ndlp =lpfc_enable_node (vport, ndlp,NLP_STE_UNUSED_NODE );if (!ndlp) -return 0 ; +return NULL ; }if ((phba->pport->port_state <LPFC_FLOGI ) && (phba->pport->port_state !=LPFC_VPORT_FAILED ))
Signature · 1 line
2.43.0
Hi Dipendra,
Perhaps the branch being referred to is out of date?
This has already been addressed in the following commit.
commit 5860d9fb5622ecd79913ac981403c612f6c8a2d8
Author: Colin Ian King <[email protected]> Date: Sat Sep 25 23:41:13 2021 +0100
scsi: lpfc: Return NULL rather than a plain 0 integer
Function lpfc_sli4_perform_vport_cvl() returns a pointer to struct lpfc_nodelist so returning a plain 0 integer isn't good practice. Fix this by returning a NULL instead.
And, the routine called lpfc_enable_node doesn’t exist anymore.
Regards,
Justin Tee
Hi Justin,
Quoted 5 lines · Justin Tee
Hi Dipendra,
Perhaps the branch being referred to is out of date?
Sorry, you are right. It is due to the branch mismatching.
Quoted 17 lines
This has already been addressed in the following commit.
commit
5860d9fb5622ecd79913ac981403c612f6c8a2d8Author: Colin Ian King <[email protected]> Date: Sat Sep 25 23:41:13 2021 +0100scsi: lpfc: Return NULL rather than a plain 0 integer
Function
lpfc_sli4_perform_vport_cvl()returns a pointer to structlpfc_nodelistso returning a plain 0 integer isn't good practice. Fix this by returning a NULL instead.Signed-off-by Colin Ian King <[email protected]>Signed-off-by Martin K. Petersen [email protected]
Quoted 4 lines
And, the routine called
lpfc_enable_nodedoesn’t exist anymore.Regards,
Justin Tee
Best Regard,
Dipendra Khadka