Skip to contentSkip to conversation

Bluetooth: hci_conn: Remove redundant memset after kzalloc

PATCH Applied Kuan-Wei Chiu 3 participants 3 messages Aug 10, 2024 – Aug 20, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Bluetooth: hci_conn: Remove redundant memset after kzalloc

Since kzalloc already zeroes the allocated memory, the subsequent memset call is unnecessary. This patch removes the redundant memset to clean up the code and enhance efficiency.

---
Note: Build test only.

 net/bluetooth/hci_conn.c | 1 -
 1 file changed, 1 deletion(-)
net/bluetooth/hci_conn.c +0 -1
index 8e48ccd2af30..8f0c9322eadb 100644
@@ -778,7 +778,6 @@ static int hci_le_big_terminate(struct hci_dev *hdev, u8 big, struct hci_conn *c
 	if (!d)
 		return -ENOMEM;
 
-	memset(d, 0, sizeof(*d));
 	d->big = big;
 	d->sync_handle = conn->sync_handle;
 
Signature · 1 line
2.34.1
#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=878440

---Test result---

Test Summary:

CheckPatch                    PASS      0.50 seconds
GitLint                       PASS      0.24 seconds
SubjectPrefix                 PASS      0.07 seconds
BuildKernel                   PASS      35.88 seconds
CheckAllWarning               PASS      31.57 seconds
CheckSparse                   PASS      56.97 seconds
CheckSmatch                   PASS      101.11 seconds
BuildKernel32                 PASS      28.19 seconds
TestRunnerSetup               PASS      530.94 seconds
TestRunner_l2cap-tester       PASS      21.71 seconds
TestRunner_iso-tester         FAIL      35.26 seconds
TestRunner_bnep-tester        PASS      5.58 seconds
TestRunner_mgmt-tester        PASS      110.01 seconds
TestRunner_rfcomm-tester      PASS      7.44 seconds
TestRunner_sco-tester         PASS      14.93 seconds
TestRunner_ioctl-tester       PASS      7.80 seconds
TestRunner_mesh-tester        PASS      5.83 seconds
TestRunner_smp-tester         PASS      7.26 seconds
TestRunner_userchan-tester    PASS      4.97 seconds
IncrementalBuild              PASS      27.06 seconds

Details
##############################
Test: TestRunner_iso-tester - FAIL
Desc: Run iso-tester with test-runner
Output:
Total: 122, Passed: 117 (95.9%), Failed: 1, Not Run: 4

Failed Test Cases
ISO Connect2 Suspend - Success Failed 6.243 seconds

---
Regards,
Linux Bluetooth

#2 lore raw
In reply to Kuan-Wei Chiu
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:

Quoted 9 lines · On Sat, 10 Aug 2024 22:14:15 +0800 you wrote:

Since kzalloc already zeroes the allocated memory, the subsequent memset call is unnecessary. This patch removes the redundant memset to clean up the code and enhance efficiency.

---
Note: Build test only.

[...]

Here is the summary with links:
- Bluetooth: hci_conn: Remove redundant memset after kzalloc
https://git.kernel.org/bluetooth/bluetooth-next/c/7a6abe8d0fdb

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html