Skip to contentSkip to conversation

pinctrl: starfive: jh7110: Correct the level trigger configuration of iev register

PATCH In review Hal Feng 2 participants 2 messages Aug 12, 2024 – Aug 23, 2024

Subsystems (3)
GPIO Pin control StarFive JH71X0 pinctrl drivers
lore
Share & tools
lore

Hal Feng

author maintainer
#0 lore raw

PATCH 1/1 pinctrl: starfive: jh7110: Correct the level trigger configuration of iev register

A mistake was made in level trigger register configuration. Correct it.

Fixes 447976ab62c5 ("pinctrl: starfive: Add StarFive JH7110 sys controller driver")
Signed-off-by Hal Feng <[email protected]>

---

Hi,

When we tested some modules that use gpio level trigger, we found the current level trigger register configuration was set wrong. Submit this patch to correct.

Best regards,
Hal

---
 drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c +2 -2
index 4ce080caa233..1d0d6c224c10 100644
@@ -793,12 +793,12 @@ static int jh7110_irq_set_type(struct irq_data *d, unsigned int trigger)
 	case IRQ_TYPE_LEVEL_HIGH:
 		irq_type  = 0;    /* 0: level triggered */
 		edge_both = 0;    /* 0: ignored */
-		polarity  = mask; /* 1: high level */
+		polarity  = 0;    /* 0: high level */
 		break;
 	case IRQ_TYPE_LEVEL_LOW:
 		irq_type  = 0;    /* 0: level triggered */
 		edge_both = 0;    /* 0: ignored */
-		polarity  = 0;    /* 0: low level */
+		polarity  = mask; /* 1: low level */
 		break;
 	default:
 		return -EINVAL;

base-commit: 7c626ce4bae1ac14f60076d00eafe71af30450ba

Signature · 1 line
2.43.2
#1 lore raw
Quoted 4 lines · Hal Feng

A mistake was made in level trigger register configuration. Correct it.

Fixes 447976ab62c5 ("pinctrl: starfive: Add StarFive JH7110 sys controller driver")
Signed-off-by Hal Feng <[email protected]>

Patch applied for fixes!

Yours,
Linus Walleij