ALSA: hda/tas2781: Use correct endian conversion
PATCH 1/1 ALSA: hda/tas2781: Use correct endian conversion
The data conversion is done rather by a wrong function. We convert to BE32, not from BE32. Although the end result must be same, this was complained by the compiler.
Fix the code again and align with another similar function tas2563_apply_calib() that does already right.
Fixes 3beddef84d90 ("ALSA: hda/tas2781: fix wrong calibrated data order")
Reported-by kernel test robot <[email protected]>
Signed-off-by Takashi Iwai <[email protected]>
--- sound/pci/hda/tas2781_hda_i2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
sound/pci/hda/tas2781_hda_i2c.c +2 -2
@@ -527,8 +527,8 @@ static void tas2781_apply_calib(struct tasdevice_priv *tas_priv)for (i =0 ; i < tas_priv->ndev; i++) {for (j =0 ; j <CALIB_MAX ; j++) { - data =get_unaligned_be32 ( - &tas_priv->cali_data.data[offset]); + data =cpu_to_be32 ( + *(uint32_t *)&tas_priv->cali_data.data[offset]); rc =tasdevice_dev_bulk_write (tas_priv, i,TASDEVICE_REG (0 , page_array[j], rgno_array[j]), (unsigned char *)&data,4 );
Signature · 1 line
2.43.0