Skip to contentSkip to conversation

x86/mm: Remove duplicate check from build_cr3()

PATCH Applied Yuntao Wang 2 participants 2 messages Aug 14, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/mm: Remove duplicate check from build_cr3()

There is already a check for 'asid > MAX_ASID_AVAILABLE' in kern_pcid(), so it is unnecessary to perform this check again in build_cr3(). Remove it.

---
 arch/x86/mm/tlb.c | 1 -
 1 file changed, 1 deletion(-)
arch/x86/mm/tlb.c +0 -1
index 44ac64f3a047..5bc87519e13e 100644
@@ -160,7 +160,6 @@ static inline unsigned long build_cr3(pgd_t *pgd, u16 asid, unsigned long lam)
 	unsigned long cr3 = __sme_pa(pgd) | lam;
 
 	if (static_cpu_has(X86_FEATURE_PCID)) {
-		VM_WARN_ON_ONCE(asid > MAX_ASID_AVAILABLE);
 		cr3 |= kern_pcid(asid);
 	} else {
 		VM_WARN_ON_ONCE(asid != 0);
Signature · 1 line
2.46.0
merge bot Applied
#1 lore raw
The following commit has been merged into the x86/mm branch of tip:

The following commit has been merged into the x86/mm branch of tip:

Commit-ID:     d4245fd4a62931aebd1c5e6b7b6f51b6ef7ad087
Gitweb:        https://git.kernel.org/tip/d4245fd4a62931aebd1c5e6b7b6f51b6ef7ad087
Author:        Yuntao Wang <[email protected]>
AuthorDate:    Wed, 14 Aug 2024 20:46:45 +08:00
Committer:     Thomas Gleixner <[email protected]>
CommitterDate: Wed, 14 Aug 2024 19:41:40 +02:00

x86/mm: Remove duplicate check from build_cr3()

There is already a check for 'asid > MAX_ASID_AVAILABLE' in kern_pcid(), so it is unnecessary to perform this check in build_cr3() right before calling kern_pcid().

Remove it.

---
 arch/x86/mm/tlb.c | 1 -
 1 file changed, 1 deletion(-)
arch/x86/mm/tlb.c +0 -1
index 09950fe..86593d1 100644
@@ -158,7 +158,6 @@ static inline unsigned long build_cr3(pgd_t *pgd, u16 asid, unsigned long lam)
 	unsigned long cr3 = __sme_pa(pgd) | lam;
 
 	if (static_cpu_has(X86_FEATURE_PCID)) {
-		VM_WARN_ON_ONCE(asid > MAX_ASID_AVAILABLE);
 		cr3 |= kern_pcid(asid);
 	} else {
 		VM_WARN_ON_ONCE(asid != 0);