perf test record.sh: Raise limit of open file descriptors
PATCH v3 1/1 perf test record.sh: Raise limit of open file descriptors
From: Veronika Molnarova <[email protected]>
Subtest for system-wide record with '--threads=cpu' option fails due to a limit of open file descriptors on systems with 128 or more CPUs as the default limit is set to 1024.
The number of open file descriptors should be slightly above nmb_events*nmb_cpus + nmb_cpus(for perf.data.n) + 4*nmb_cpus(for pipes), which equals 8*nmb_cpus. Therefore, temporarily raise the limit to 16*nmb_cpus for the test.
Cc Adrian Hunter <[email protected]>
Cc Athira Rajeev <[email protected]>
Cc Ian Rogers <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Kajol Jain <[email protected]>
Cc Michael Petlan <[email protected]>
Cc Radostin Stoyanov <[email protected]>
Signed-off-by Veronika Molnarova <[email protected]>
---
v2: Rebase the patch to apply upstream
v3: Switch to bash to fix shellcheck warnings
--- tools/perf/tests/shell/record.sh | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-)
tools/perf/tests/shell/record.sh +18 -1
@@ -1,4 +1,4 @@ -#!/bin/sh +#!/bin/bash # perf record tests # SPDX-License-Identifier: GPL-2.0
@@ -22,6 +22,15 @@ cpu_pmu_dir="/sys/bus/event_source/devices/cpu*" br_cntr_file="/caps/branch_counter_nr" br_cntr_output="branch stack counters" +# With option --threads=cpu the number of open file descriptors should be +# equal to sum of: nmb_cpus * nmb_events (2+dummy), +# nmb_threads for perf.data.n (equal to nmb_cpus) and +# 2*nmb_cpus of pipes = 4*nmb_cpus (each pipe has 2 ends) +# All together it needs 8*nmb_cpus file descriptors plus some are also used +# outside of testing, thus raising the limit to 16*nmb_cpus +min_fd_limit=$(($(getconf _NPROCESSORS_ONLN) * 16)) +default_fd_limit=$(ulimit -Sn) + cleanup() { rm -rf "${perfdata}" rm -rf "${perfdata}".old
@@ -190,11 +199,19 @@ test_branch_counter() { echo "Basic branch counter test [Success]" } +# raise the limit of file descriptors to required minimum +if [ $default_fd_limit -lt $min_fd_limit ]; then + ulimit -Sn $min_fd_limit +fi + test_per_thread test_register_capture test_system_wide test_workload test_branch_counter +# restore the default value +ulimit -Sn $default_fd_limit + cleanup exit $err
Signature · 1 line
2.43.0