Skip to contentSkip to conversation

dt-bindings: misc: qcom,fastrpc: document new domain ID

PATCH Applied Bartosz Golaszewski 3 participants 8 messages Aug 16, 2024 – Aug 20, 2024

Subsystems (4)
Device tree bindings Arm Qualcomm mailing list Arm Qualcomm support Qualcomm fastrpc driver
lore
Share & tools
lore

Bartosz Golaszewski

author
#0 lore raw

PATCH 1/2 dt-bindings: misc: qcom,fastrpc: document new domain ID

From: Bartosz Golaszewski <[email protected]>

Add "cdsp1" as the new supported label for the CDSP1 fastrpc domain.

Signed-off-by Bartosz Golaszewski <[email protected]>
---
 Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml +1 -0
index c27a8f33d8d7..2a5b18982804 100644
@@ -26,6 +26,7 @@ properties:
       - mdsp
       - sdsp
       - cdsp
+      - cdsp1
 
   memory-region:
     maxItems: 1
Signature · 1 line
2.43.0
author
#1 lore raw

PATCH 2/2 arm64: dts: qcom: sa8775p: fix the fastrpc label

From: Bartosz Golaszewski <[email protected]>

The fastrpc driver uses the label to determine the domain ID and create the device nodes. It should be "cdsp1" as this is the engine we use here.

Fixes df54dcb34ff2 ("arm64: dts: qcom: sa8775p: add ADSP, CDSP and GPDSP nodes")
Reported-by Ekansh Gupta <[email protected]>
Signed-off-by Bartosz Golaszewski <[email protected]>
---
 arch/arm64/boot/dts/qcom/sa8775p.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/sa8775p.dtsi +1 -1
index 801e8a92359d..5b9b68c634f5 100644
@@ -4046,7 +4046,7 @@ IPCC_MPROC_SIGNAL_GLINK_QMP
 				fastrpc {
 					compatible = "qcom,fastrpc";
 					qcom,glink-channels = "fastrpcglink-apps-dsp";
-					label = "cdsp";
+					label = "cdsp1";
 					#address-cells = <1>;
 					#size-cells = <0>;
Signature · 1 line
2.43.0
Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] arm64: dts: qcom: sa8775p: fix the fastrpc label

Quoted 8 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

The fastrpc driver uses the label to determine the domain ID and create the device nodes. It should be "cdsp1" as this is the engine we use here.

Fixes df54dcb34ff2 ("arm64: dts: qcom: sa8775p: add ADSP, CDSP and GPDSP nodes")
Reported-by Ekansh Gupta <[email protected]>
Signed-off-by Bartosz Golaszewski <[email protected]>
Reviewed-by Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

#3 lore raw
In reply to Bartosz Golaszewski
Quoted 14 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add "cdsp1" as the new supported label for the CDSP1 fastrpc domain.

Signed-off-by Bartosz Golaszewski <[email protected]>
---
 Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml +0 -0
index c27a8f33d8d7..2a5b18982804 100644

Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml properties: · line 29

Quoted 4 lines
Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml +1 -0
@@ -26,6 +26,7 @@ properties:
       - mdsp
       - sdsp
       - cdsp
+      - cdsp1

Are there more than one cdsp domains? Why adding suffixes? Driver source code does not have "cdsp1" domain, so this is confusing.

Best regards,
Krzysztof

author
#4 lore raw
Quoted 24 lines · Krzysztof Kozlowski
Quoted 14 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add "cdsp1" as the new supported label for the CDSP1 fastrpc domain.

Signed-off-by Bartosz Golaszewski <[email protected]>
---
 Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml +0 -0
index c27a8f33d8d7..2a5b18982804 100644

Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml properties: · line 29

Quoted 4 lines
Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml +1 -0
@@ -26,6 +26,7 @@ properties:
       - mdsp
       - sdsp
       - cdsp
+      - cdsp1

Are there more than one cdsp domains? Why adding suffixes? Driver source code does not have "cdsp1" domain, so this is confusing.

Quoted 3 lines

Best regards,
Krzysztof

It does, Srini picked up this patch earlier today. I'm not an expert in fast RPC but it looks like the domain ID number matters here.

Bart

[1] https://lore.kernel.org/all/20240805-topic-sa8775p-iot-remoteproc-v4-4-86affdc72c04@linaro.org/

#5 lore raw
Quoted 25 lines · Bartosz Golaszewski
Quoted 24 lines · Krzysztof Kozlowski
Quoted 14 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add "cdsp1" as the new supported label for the CDSP1 fastrpc domain.

Signed-off-by Bartosz Golaszewski <[email protected]>
---
 Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml +0 -0
index c27a8f33d8d7..2a5b18982804 100644

Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml properties: · line 29

Quoted 4 lines
Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml +1 -0
@@ -26,6 +26,7 @@ properties:
       - mdsp
       - sdsp
       - cdsp
+      - cdsp1

Are there more than one cdsp domains? Why adding suffixes? Driver source code does not have "cdsp1" domain, so this is confusing.

Quoted 6 lines
Quoted 3 lines

Best regards,
Krzysztof

It does, Srini picked up this patch earlier today. I'm not an expert in fast RPC but it looks like the domain ID number matters here.

Ah, ok, I did not see driver change here so it was a bit confusing.

Best regards,
Krzysztof

maintainer Applied
#7 lore raw

Re: (subset) [PATCH 1/2] dt-bindings: misc: qcom,fastrpc: document new domain ID

In reply to Bartosz Golaszewski
Quoted 5 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add "cdsp1" as the new supported label for the CDSP1 fastrpc domain.

Applied, thanks!

[2/2] arm64: dts: qcom: sa8775p: fix the fastrpc label

      commit: b45af698d5114f9b666c7d8b58a9111d0526d7f7

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>