Revert "spi: ppc4xx: handle irq_of_parse_and_map() errors"
PATCH 1/1 Revert "spi: ppc4xx: handle irq_of_parse_and_map() errors"
This reverts commit f1011ba20b83da3ee70dcb4a6d9d282a718916fa.
The commit had been applied twice as
0f245463b01e ("spi: ppc4xx: handle irq_of_parse_and_map() errors")
and
f1011ba20b83 ("spi: ppc4xx: handle irq_of_parse_and_map() errors")
Revert the latter one.
--- drivers/spi/spi-ppc4xx.c | 3 --- 1 file changed, 3 deletions(-)
drivers/spi/spi-ppc4xx.c +0 -3
@@ -416,9 +416,6 @@ static int spi_ppc4xx_of_probe(struct platform_device *op) goto free_host; hw->irqnum = ret; -if (hw->irqnum <=0 ) - goto free_host; - ret =request_irq (hw->irqnum, spi_ppc4xx_int,0 ,"spi_ppc4xx_of" , (void *)hw);if (ret) {
Signature · 1 line
2.43.0.rc1.1336.g36b5255a03ac
Mark Brown
maintainerQuoted 1 line · Andy Shevchenko
This reverts commit
f1011ba20b83da3ee70dcb4a6d9d282a718916fa.
Please include human readable descriptions of things like commits and issues being discussed in e-mail in your mails, this makes them much easier for humans to read especially when they have no internet access. I do frequently catch up on my mail on flights or while otherwise travelling so this is even more pressing for me than just being about making things a bit easier to read.
Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.
Quoted 9 lines · Mark Brown
Quoted 1 line · Andy Shevchenko
This reverts commit
f1011ba20b83da3ee70dcb4a6d9d282a718916fa.Please include human readable descriptions of things like commits and issues being discussed in e-mail in your mails, this makes them much easier for humans to read especially when they have no internet access. I do frequently catch up on my mail on flights or while otherwise travelling so this is even more pressing for me than just being about making things a bit easier to read.
It has the human-readable text just below that line.
Quoted 5 lines
Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.
This is a pure and clean revert, not sure if we need to hide that fact.
P.S.
You can just revert yourself the second commit if it makes it easier to perform, I'm fine with either.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Mark Brown
maintainerQuoted 9 lines · Andy Shevchenko
Quoted 5 lines · Mark Brown
Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.
This is a pure and clean revert, not sure if we need to hide that fact.
This is not an issue with the word "revert", it is an issue with the formatting of the subject line.
Quoted 9 lines · Mark Brown
Quoted 7 lines · Andy Shevchenko
Quoted 5 lines · Mark Brown
Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.
Quoted 4 lines
Quoted 1 line
This is a pure and clean revert, not sure if we need to hide that fact.
This is not an issue with the word "revert", it is an issue with the formatting of the subject line.
So, should I send a v2?
Signature · 2 lines
With Best Regards, Andy Shevchenko