Skip to contentSkip to conversation

kunit-overflow-fix-ub-in-overflow_allocation_test.patch removed from -mm tree

merged Andrew Morton 1 participant 1 message Aug 20, 2024 Stable branch

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: kunit/overflow: fix UB in overflow_allocation_test
has been removed from the -mm tree. Its filename was
kunit-overflow-fix-ub-in-overflow_allocation_test.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: Ivan Orlov <[email protected]>
Subject: kunit/overflow: fix UB in overflow_allocation_test
Date: Thu, 15 Aug 2024 01:04:31 +0100

The 'device_name' array doesn't exist out of the 'overflow_allocation_test' function scope. However, it is being used as a driver name when calling 'kunit_driver_create' from 'kunit_device_register'. It produces the kernel panic with KASAN enabled due to undefined behaviour.

Since this variable is used in one place only, remove it and pass the device name into kunit_device_register directly as an ascii string.

Fixes ca90800a91ba ("test_overflow: Add memory allocation overflow tests")
Cc Kees Cook <[email protected]>

---

 lib/overflow_kunit.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
lib/overflow_kunit.c renamed from lib/overflow_kunit.c~kunit-overflow-fix-ub-in-overflow_allocation_test +1 -2
@@ -668,7 +668,6 @@ DEFINE_TEST_ALLOC(devm_kzalloc,  devm_kf
 
 static void overflow_allocation_test(struct kunit *test)
 {
-	const char device_name[] = "overflow-test";
 	struct device *dev;
 	int count = 0;
 
@@ -678,7 +677,7 @@ static void overflow_allocation_test(str
 } while (0)
 
 	/* Create dummy device for devm_kmalloc()-family tests. */
-	dev = kunit_device_register(test, device_name);
+	dev = kunit_device_register(test, "overflow-test");
 	KUNIT_ASSERT_FALSE_MSG(test, IS_ERR(dev),
 			       "Cannot register test device\n");
 

_

Patches currently in -mm which might be from [email protected] are