Skip to contentSkip to conversation

remoteproc: k3-r5: Delay notification of wakeup event

PATCH Applied Beleswar Padhi 2 participants 4 messages Aug 20, 2024 – Sep 4, 2024 Remote processor (remoteproc)

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 remoteproc: k3-r5: Delay notification of wakeup event

From: Udit Kumar <[email protected]>

Few times, core1 was scheduled to boot first before core0, which leads to error:

'k3_r5_rproc_start: can not start core 1 before core 0'.

This was happening due to some scheduling between prepare and start callback. The probe function waits for event, which is getting triggered by prepare callback. To avoid above condition move event trigger to start instead of prepare callback.

Fixes 61f6f68447ab ("remoteproc: k3-r5: Wait for core0 power-up before powering up core1")
[ Applied wakeup event trigger only for Split-Mode booted rprocs ]

---
v2: Changelog:
* Mathieu
1) Rebased changes on top of -next-20240820 tag.

Link to v1:
https://lore.kernel.org/all/[email protected]/

 drivers/remoteproc/ti_k3_r5_remoteproc.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/remoteproc/ti_k3_r5_remoteproc.c +3 -2
index 8a63a9360c0f..e61e53381abc 100644
@@ -469,8 +469,6 @@ static int k3_r5_rproc_prepare(struct rproc *rproc)
 			ret);
 		return ret;
 	}
-	core->released_from_reset = true;
-	wake_up_interruptible(&cluster->core_transition);
 
 	/*
 	 * Newer IP revisions like on J7200 SoCs support h/w auto-initialization
@@ -587,6 +585,9 @@ static int k3_r5_rproc_start(struct rproc *rproc)
 		ret = k3_r5_core_run(core);
 		if (ret)
 			return ret;
+
+		core->released_from_reset = true;
+		wake_up_interruptible(&cluster->core_transition);
 	}
 
 	return 0;
Signature · 1 line
2.34.1
#1 lore raw

Hi Mathieu,

Quoted 5 lines · Beleswar Padhi

From: Udit Kumar <[email protected]>

Few times, core1 was scheduled to boot first before core0, which leads to error:

Quoted 8 lines

'k3_r5_rproc_start: can not start core 1 before core 0'.

This was happening due to some scheduling between prepare and start callback. The probe function waits for event, which is getting triggered by prepare callback. To avoid above condition move event trigger to start instead of prepare callback.

Fixes 61f6f68447ab ("remoteproc: k3-r5: Wait for core0 power-up before powering up core1")

Please put this patch on hold. I have some additional changelog that should go in v3.

Thanks,
Beleswar

Quoted 37 lines
[ Applied wakeup event trigger only for Split-Mode booted rprocs ]

---
v2: Changelog:
* Mathieu
1) Rebased changes on top of -next-20240820 tag.

Link to v1:
https://lore.kernel.org/all/[email protected]/

  drivers/remoteproc/ti_k3_r5_remoteproc.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)
drivers/remoteproc/ti_k3_r5_remoteproc.c +3 -2
index 8a63a9360c0f..e61e53381abc 100644
@@ -469,8 +469,6 @@ static int k3_r5_rproc_prepare(struct rproc *rproc)
  			ret);
  		return ret;
  	}
-	core->released_from_reset = true;
-	wake_up_interruptible(&cluster->core_transition);
 
  	/*
  	 * Newer IP revisions like on J7200 SoCs support h/w auto-initialization
@@ -587,6 +585,9 @@ static int k3_r5_rproc_start(struct rproc *rproc)
  		ret = k3_r5_core_run(core);
  		if (ret)
  			return ret;
+
+		core->released_from_reset = true;
+		wake_up_interruptible(&cluster->core_transition);
  	}
 
  	return 0;
maintainer Applied
#2 lore raw
Quoted 16 lines · Beleswar Prasad Padhi

Hi Mathieu,

Quoted 12 lines · Beleswar Padhi

From: Udit Kumar <[email protected]>

Few times, core1 was scheduled to boot first before core0, which leads to error:

'k3_r5_rproc_start: can not start core 1 before core 0'.

This was happening due to some scheduling between prepare and start callback. The probe function waits for event, which is getting triggered by prepare callback. To avoid above condition move event trigger to start instead of prepare callback.

Quoted 6 lines
Quoted 1 line
Fixes 61f6f68447ab ("remoteproc: k3-r5: Wait for core0 power-up before powering up core1")

Please put this patch on hold. I have some additional changelog that should go in v3.

I applied this patch a couple of weeks ago - are those changes to the code? If so please send another patch on top of rproc-next.

Quoted 40 lines

Thanks,
Beleswar

Quoted 37 lines
[ Applied wakeup event trigger only for Split-Mode booted rprocs ]

---
v2: Changelog:
* Mathieu
1) Rebased changes on top of -next-20240820 tag.

Link to v1:
https://lore.kernel.org/all/[email protected]/

  drivers/remoteproc/ti_k3_r5_remoteproc.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)
drivers/remoteproc/ti_k3_r5_remoteproc.c +3 -2
index 8a63a9360c0f..e61e53381abc 100644
@@ -469,8 +469,6 @@ static int k3_r5_rproc_prepare(struct rproc *rproc)
                      ret);
              return ret;
      }
-     core->released_from_reset = true;
-     wake_up_interruptible(&cluster->core_transition);
 
      /*
       * Newer IP revisions like on J7200 SoCs support h/w auto-initialization
@@ -587,6 +585,9 @@ static int k3_r5_rproc_start(struct rproc *rproc)
              ret = k3_r5_core_run(core);
              if (ret)
                      return ret;
+
+             core->released_from_reset = true;
+             wake_up_interruptible(&cluster->core_transition);
      }
 
      return 0;
#3 lore raw
Quoted 16 lines · Mathieu Poirier
Quoted 15 lines · Beleswar Prasad Padhi

Hi Mathieu,

Quoted 12 lines · Beleswar Padhi

From: Udit Kumar <[email protected]>

Few times, core1 was scheduled to boot first before core0, which leads to error:

'k3_r5_rproc_start: can not start core 1 before core 0'.

This was happening due to some scheduling between prepare and start callback. The probe function waits for event, which is getting triggered by prepare callback. To avoid above condition move event trigger to start instead of prepare callback.

Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Fixes 61f6f68447ab ("remoteproc: k3-r5: Wait for core0 power-up before powering up core1")

Please put this patch on hold. I have some additional changelog that should go in v3.

I applied this patch a couple of weeks ago - are those changes to the code? If so please send another patch on top of rproc-next.

Understood. Those are code changes, I will post another patch series for the same.

Thanks,
Beleswar

Quoted 41 lines
Quoted 41 lines

Thanks,
Beleswar

Quoted 37 lines
[ Applied wakeup event trigger only for Split-Mode booted rprocs ]

---
v2: Changelog:
* Mathieu
1) Rebased changes on top of -next-20240820 tag.

Link to v1:
https://lore.kernel.org/all/[email protected]/

   drivers/remoteproc/ti_k3_r5_remoteproc.c | 5 +++--
   1 file changed, 3 insertions(+), 2 deletions(-)
drivers/remoteproc/ti_k3_r5_remoteproc.c +3 -2
index 8a63a9360c0f..e61e53381abc 100644
@@ -469,8 +469,6 @@ static int k3_r5_rproc_prepare(struct rproc *rproc)
                       ret);
               return ret;
       }
-     core->released_from_reset = true;
-     wake_up_interruptible(&cluster->core_transition);
 
       /*
        * Newer IP revisions like on J7200 SoCs support h/w auto-initialization
@@ -587,6 +585,9 @@ static int k3_r5_rproc_start(struct rproc *rproc)
               ret = k3_r5_core_run(core);
               if (ret)
                       return ret;
+
+             core->released_from_reset = true;
+             wake_up_interruptible(&cluster->core_transition);
       }
 
       return 0;